Update TTD replay to match recent JsCreate*Function changes #4590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-kaufman
approved these changes
Jan 23, 2018
MSLaguana
reviewed
Jan 23, 2018
lib/Runtime/Debug/TTActionEvents.cpp
Outdated
| Js::Var nameVar = InflateVarInReplay(executeContext, GetVarItem_0(action)); | ||
|
|
||
| Js::JavascriptString* name = nullptr; | ||
| if(nameVar != nullptr) |
Contributor
There was a problem hiding this comment.
For a closer match with the non-TTD code, should this check nameVar != JS_INVALID_REFERENCE? And maybe also call it metadata, even though it is currently just a name?
Contributor
Author
There was a problem hiding this comment.
JS_INVALID_REFERENCE isn't used internally, so I didn't make that change, but I did update the variable to metadata.
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…t JsCreate*Function changes Merge pull request #4590 from kfarnung:ttdfunction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.