BVSparse: keep 'last found' for fast fromIndex discovery #4588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| BVSparseNode<TAllocator> * | ||
| BVSparse<TAllocator>::DeleteNode(BVSparseNode *node, bool bResetLastUsed) | ||
| { | ||
| this->tail = nullptr; |
Contributor
There was a problem hiding this comment.
Do we necessarily only delete the last node? If so, shouldn't we update the tail to be the new last node?
Collaborator
Author
There was a problem hiding this comment.
updated the variable name.
Contributor
There was a problem hiding this comment.
Ah, that clears things up a lot, thanks!
e95afaf to
8692a9d
Compare
8692a9d to
136a7b4
Compare
Collaborator
Author
|
@Penguinwizzard Thanks for the review! |
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…ex discovery Merge pull request #4588 from obastemur:faster_bvsparse Helps the number of tests not to timeout on CI machines.
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…st fromIndex discovery Merge pull request #4588 from obastemur:faster_bvsparse Helps the number of tests not to timeout on CI machines.
chakrabot
pushed a commit
that referenced
this pull request
Jan 23, 2018
…found' for fast fromIndex discovery Merge pull request #4588 from obastemur:faster_bvsparse Helps the number of tests not to timeout on CI machines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps the number of tests not to timeout on CI machines.