Fixing usage of arguments inside eval in arrow functions #4568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an inner arrow function has eval it may end up using arguments symbol. So we have to mark the parent that arguments is in use.
Contributor
Author
|
Fixes the issue #1209. |
pleath
approved these changes
Jan 17, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 18, 2018
chakrabot
pushed a commit
that referenced
this pull request
Jan 18, 2018
…al in arrow functions Merge pull request #4568 from aneeshdk:ArrowEvalArgumentsIssue When an inner arrow function has eval it may end up using arguments symbol. So we have to mark the parent that arguments is in use.
chakrabot
pushed a commit
that referenced
this pull request
Jan 18, 2018
…nts inside eval in arrow functions Merge pull request #4568 from aneeshdk:ArrowEvalArgumentsIssue When an inner arrow function has eval it may end up using arguments symbol. So we have to mark the parent that arguments is in use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an inner arrow function has eval it may end up using arguments symbol. So we have to mark the parent that arguments is in use.