Fixing the cross context behaviour in DebugEval #4565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@akroshg @curtisman @agarwal-sandeep Can you please take a look? |
curtisman
reviewed
Jan 17, 2018
| pfuncScript = ScriptFunction::FromVar(CrossSite::MarshalVar(debugEvalScriptContext, pfuncScript)); | ||
| } | ||
|
|
||
| if (useEvalMap && !found) |
Contributor
There was a problem hiding this comment.
Can you disable useEvalMap with debugEvalScriptContext
curtisman
approved these changes
Jan 17, 2018
DebugEval method is invoked in debug eval script context. Then the string that user enters is executed in the target script context. The newly created function object belongs to target script context but the current top of the stack is pointing to the debug eval script context. We have to marshall the function object before invoking it to fix the stack.
472fc51 to
8c643bc
Compare
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
Merge pull request #4565 from aneeshdk:DebugEvalCrossContextIssue DebugEval method is invoked in debug eval script context. Then the string that user enters is executed in the target script context. The newly created function object belongs to target script context but the current top of the stack is pointing to the debug eval script context. We have to marshall the function object before invoking it to fix the stack.
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
…in DebugEval Merge pull request #4565 from aneeshdk:DebugEvalCrossContextIssue DebugEval method is invoked in debug eval script context. Then the string that user enters is executed in the target script context. The newly created function object belongs to target script context but the current top of the stack is pointing to the debug eval script context. We have to marshall the function object before invoking it to fix the stack.
chakrabot
pushed a commit
that referenced
this pull request
Jan 17, 2018
…xt behaviour in DebugEval Merge pull request #4565 from aneeshdk:DebugEvalCrossContextIssue DebugEval method is invoked in debug eval script context. Then the string that user enters is executed in the target script context. The newly created function object belongs to target script context but the current top of the stack is pointing to the debug eval script context. We have to marshall the function object before invoking it to fix the stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugEval method is invoked in debug eval script context. Then the string that user enters is executed in the target script context. The newly created function object belongs to target script context but the current top of the stack is pointing to the debug eval script context. We have to marshall the function object before invoking it to fix the stack.