Skip to content

fix scenario function table deletion is not transferred to background thread #4560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 1 commit into from
Jan 22, 2018
Merged

fix scenario function table deletion is not transferred to background thread #4560

chakrabot merged 1 commit into from
Jan 22, 2018

Conversation

@leirocks
Copy link
Contributor

@leirocks leirocks commented Jan 16, 2018

No description provided.

@leirocks leirocks requested a review from MikeHolman January 16, 2018 21:45
@leirocks leirocks force-pushed the ftfix branch 2 times, most recently from 33f2b2d to 5b17dce Compare January 17, 2018 19:24
@leirocks leirocks requested a review from curtisman January 18, 2018 20:01
@chakrabot chakrabot merged commit 0f4fff7 into chakra-core:release/1.8 Jan 22, 2018
chakrabot pushed a commit that referenced this pull request Jan 22, 2018
@leirocks
[MERGE #4560 @leirocks] simplify xData deletion
c60cf51 
Merge pull request #4560 from leirocks:ftfix

change to not using jit code deletion job to do the work, instead always do it in side channel and before new xData registration
chakrabot pushed a commit that referenced this pull request Jan 22, 2018
@leirocks
[1.8>1.9] [MERGE #4560 @leirocks] simplify xData deletion
cfcbe3b 
Merge pull request #4560 from leirocks:ftfix

change to not using jit code deletion job to do the work, instead always do it in side channel and before new xData registration
chakrabot pushed a commit that referenced this pull request Jan 22, 2018
@leirocks
[1.9>master] [1.8>1.9] [MERGE #4560 @leirocks] simplify xData deletion
065f718 
Merge pull request #4560 from leirocks:ftfix

change to not using jit code deletion job to do the work, instead always do it in side channel and before new xData registration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curtisman curtisman Awaiting requested review from curtisman

1 more reviewer

@MikeHolman MikeHolman MikeHolman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leirocks @MikeHolman @chakrabot