disable timing out test on osx #4556
Conversation
| <!-- todo:: On unix platforms there is more stack available, | ||
| so we need to find the right limit to test in order to not timeout --> | ||
| <tags>exclude_dynapogo</tags> | ||
| <tags>exclude_dynapogo,exclude_mac</tags> |
There was a problem hiding this comment.
The TODO above doesn't line up with the PR description -- should it be removed or changed to clarify why we are now excluding mac? Also, I don't know exactly how the Slow tag is used, but I know it exists for other tests, if thats preferable.
There was a problem hiding this comment.
It's not exactly clear, but I think the idea is that we want a count that is high enough to test out of stack but low enough to not time out. Seems on osx we hit timeout first. It's not really that important to test on all platforms, so I'm gong to leave it as is.
And the slow tag will disable from running in the CI and we will only run in nightly builds (which I think may be Windows only). It's useful to have in CI, so I'd rather not add slow tag.
Merge pull request #4556 from MikeHolman:disableslowosx It's a slow test in general and the OSX machines are very slow so this is timing out.
Merge pull request #4556 from MikeHolman:disableslowosx It's a slow test in general and the OSX machines are very slow so this is timing out.
…est on osx Merge pull request #4556 from MikeHolman:disableslowosx It's a slow test in general and the OSX machines are very slow so this is timing out.
It's a slow test in general and the OSX machines are very slow so this is timing out.