Skip to content

Disabling bytecode verification tests for lite ci build #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 1 commit into from
Jan 11, 2018
Merged

Disabling bytecode verification tests for lite ci build #4533

chakrabot merged 1 commit into from
Jan 11, 2018

Conversation

@MSLaguana
Copy link
Contributor

@MSLaguana MSLaguana commented Jan 11, 2018

No description provided.

@jackhorton
Copy link
Contributor

jackhorton commented Jan 11, 2018

Don't JsBuiltIns need this too?

@MSLaguana
Copy link
Contributor Author

MSLaguana commented Jan 11, 2018

Yes it does, but they don't exist in 1.7

@chakrabot chakrabot merged commit 513eea3 into chakra-core:release/1.7 Jan 11, 2018
chakrabot pushed a commit that referenced this pull request Jan 11, 2018
@MSLaguana
[MERGE #4533 @MSLaguana] Disabling bytecode verification tests for li…
cf780ac 
…te ci build

Merge pull request #4533 from MSLaguana:fixLiteTests
chakrabot pushed a commit that referenced this pull request Jan 11, 2018
@MSLaguana
[1.7>1.8] [MERGE #4533 @MSLaguana] Disabling bytecode verification te…
711be62 
…sts for lite ci build

Merge pull request #4533 from MSLaguana:fixLiteTests
chakrabot pushed a commit that referenced this pull request Jan 11, 2018
@MSLaguana
[1.8>master] [1.7>1.8] [MERGE #4533 @MSLaguana] Disabling bytecode ve…
7e29875 
…rification tests for lite ci build

Merge pull request #4533 from MSLaguana:fixLiteTests
@Cellule
Copy link
Contributor

Cellule commented Jan 11, 2018

Does the Lite build even exist in 1.7 ?
I don't see a CI run to test a Lite build on this PR (which is why I missed it initially).

@MSLaguana MSLaguana deleted the fixLiteTests branch January 11, 2018 20:46
@MSLaguana
Copy link
Contributor Author

MSLaguana commented Jan 11, 2018

Probably not actually, but I thought I'd make the change here so it'll travel everywhere necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boingoing boingoing Awaiting requested review from boingoing

@Cellule Cellule Awaiting requested review from Cellule

@jackhorton jackhorton Awaiting requested review from jackhorton

1 more reviewer

@rajatd rajatd rajatd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MSLaguana @jackhorton @Cellule @rajatd @chakrabot