xplat: retry clang network #4518
Conversation
| DOWNLOAD_HELPER() { | ||
| WGET_CTR=1 | ||
| while [ 1 ]; do | ||
| wget --no-dns-cache --tries=3 --retry-connrefused --waitretry=3 $1 >/dev/null 2>&1 |
There was a problem hiding this comment.
Is there a reason you have omitted --quiet?
There was a problem hiding this comment.
Because it's not used.
There was a problem hiding this comment.
Well, I would imagine that we either use wget --quiet or wget > /dev/null 2>&1, we have just opted for the latter here?
| tar -xf "llvm-${LLVM_VERSION}.src.tar.xz" | ||
| DOWNLOAD_HELPER "http://llvm.org/releases/${LLVM_VERSION}/llvm-${LLVM_VERSION}.src.tar.xz" | ||
|
|
||
| tar xf "llvm-${LLVM_VERSION}.src.tar.xz" |
There was a problem hiding this comment.
Why go from -xf to just xf?
There was a problem hiding this comment.
no particular reason
| exit 1 | ||
| fi | ||
| WGET_CTR=$($WGET_CTR + 1) | ||
| echo "${WGET_CTR}. try...." |
There was a problem hiding this comment.
nit: "wget $1 failed (attempt $WGET_CTR). Retrying..." ?
There was a problem hiding this comment.
currently it prints 3. try... well, it must have failed right?
There was a problem hiding this comment.
++ we are not interested for whatever reason the download was failed. (as long as it works eventually)
There was a problem hiding this comment.
Yeah, but I would argue theres no reason to not have a more descriptive sentence here if it helps future trouble shooting or general developer experience.
There was a problem hiding this comment.
Could be. IMHO the output from WGET is more useful than anything we might say here.
FWIW, after this PR, this tool will exit with the right exit code in case one of the packages above wasn't downloaded properly. Package creator will recognize the issue now.
We have tooling build failures on xplat, due to issues with clang source files network. This PR implements retry like tooling around clang source downloading
|
@MSLaguana @jackhorton anything that you feel strong or good to go? |
|
|
Merge pull request #4518 from obastemur:down_fix We have tooling build failures on xplat, due to issues with clang source files network. This PR implements retry like tooling around clang source downloader
Merge pull request #4518 from obastemur:down_fix We have tooling build failures on xplat, due to issues with clang source files network. This PR implements retry like tooling around clang source downloader
…twork Merge pull request #4518 from obastemur:down_fix We have tooling build failures on xplat, due to issues with clang source files network. This PR implements retry like tooling around clang source downloader
We have tooling build failures on xplat, due to issues with clang source files network. This PR implements retry like tooling around clang source downloader