Fixes an issue with flaky 262 test #4492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhorton
reviewed
Jan 2, 2018
|
|
||
| // OSX does build does not support $262 as filename | ||
| const wchar_t $262[] = | ||
| const char Test262[] = |
Contributor
There was a problem hiding this comment.
While we are changing code here, can we add a comment here and/or in 262.js that explains this code pattern?
test/262/262test.js
Outdated
| } | ||
|
|
||
| message += 'Expected SameValue(«' + String(actual) + '», «' + String(unexpected) + '») to be false'; | ||
| message += 'Expected SameValue(<' + String(actual) + '>, <' + String(unexpected) + '>) to be false'; |
Contributor
There was a problem hiding this comment.
The benefit of keeping the unicode angle brackets is that that is what test262 prints itself (like when run through test262-harness)
Collaborator
Author
|
@leirocks could you please review |
Collaborator
Author
|
@jackhorton @leirocks thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4405