Fixing x86 stack walking issue. #4252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chakrabot
pushed a commit
that referenced
this pull request
Nov 16, 2017
Merge pull request #4252 from MSLaguana:fixStackWalk The code to deal with x86 aligned return values was too loose, occasionally resulting in missing stack frames. This change tries to more accurately determine when the return value has shifted due to alignment.
chakrabot
pushed a commit
that referenced
this pull request
Nov 18, 2017
Merge pull request #4252 from MSLaguana:fixStackWalk The code to deal with x86 aligned return values was too loose, occasionally resulting in missing stack frames. This change tries to more accurately determine when the return value has shifted due to alignment.
chakrabot
pushed a commit
that referenced
this pull request
Nov 18, 2017
…ing issue. Merge pull request #4252 from MSLaguana:fixStackWalk The code to deal with x86 aligned return values was too loose, occasionally resulting in missing stack frames. This change tries to more accurately determine when the return value has shifted due to alignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to deal with x86 aligned return values was too loose, occasionally resulting in missing stack frames. This change tries to more accurately determine when the return value has shifted due to alignment.