Skip to content

Intl-ICU on release/1.7 fixups #4217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chakrabot merged 2 commits into from
Nov 14, 2017
Merged

Intl-ICU on release/1.7 fixups #4217

chakrabot merged 2 commits into from
Nov 14, 2017

Conversation

@jackhorton
Copy link
Contributor

@jackhorton jackhorton commented Nov 13, 2017 •
edited
Loading

This pull supersedes #4187

@jackhorton jackhorton mentioned this pull request Nov 13, 2017
Closed
boingoing
boingoing approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@boingoing boingoing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dilijev
dilijev approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@dilijev dilijev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chakrabot chakrabot merged commit dc0869f into chakra-core:release/1.7 Nov 14, 2017
chakrabot pushed a commit that referenced this pull request Nov 14, 2017
@jackhorton
[MERGE #4217 @jackhorton] Intl-ICU on release/1.7 fixups
7b9c916 
Merge pull request #4217 from jackhorton:fix-mergeback-break

This pull supersedes #4187
@jackhorton jackhorton deleted the fix-mergeback-break branch November 14, 2017 17:28
chakrabot pushed a commit that referenced this pull request Nov 14, 2017
@jackhorton
[1.7>1.8] [MERGE #4217 @jackhorton] Intl-ICU on release/1.7 fixups
b0cac1c 
Merge pull request #4217 from jackhorton:fix-mergeback-break

This pull supersedes #4187
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@dilijev dilijev dilijev approved these changes

@boingoing boingoing boingoing approved these changes

@MSLaguana MSLaguana MSLaguana approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jackhorton @dilijev @boingoing @MSLaguana @chakrabot