[optional] Improve OS14363556 #4100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Did you verify that this recovers the whole regression? I had tried that change but only saw a partial recovery... |
Collaborator
Author
|
@LouisLaf wasn't able to observe regression on xplat / Clang LTO build after this PR. This could be compiler specific. Taking an additional look on Windows. |
Collaborator
Author
|
Added bench results to VSO item. Unable to measure any perf diff (before after) the related changes. I would like to merge this in anyway and keep the TODO FNV1a mention for any necessary change in future. ? |
Collaborator
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
Nov 3, 2017
Merge pull request #4100 from obastemur:rem_xor Discussion is on VSO.
chakrabot
pushed a commit
that referenced
this pull request
Nov 3, 2017
Merge pull request #4100 from obastemur:rem_xor Discussion is on VSO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion is on VSO.