remove old interceptors code and open a space under TypeFlagMask #3717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e93392e to
3831e42
Compare
Contributor
|
Maybe @curtisman or @Yongqu remember how this is used... |
Contributor
|
It should be fine from a TTD perspective. My asserts were in there as a purely defensive measure. |
Collaborator
Author
|
@curtisman ping |
curtisman
approved these changes
Nov 10, 2017
Collaborator
Author
|
@curtisman Thanks for the review |
Collaborator
Author
|
Why it's waiting? This will target master branch. |
Collaborator
Author
|
Will rebase this to |
CanHaveInterceptors was being triggered heavily on some of the benchmarks and looking deeper shown that there is no reason keeping this code around. Besides.. Removing this, comes with a very useful space within TypeFlagMask that I could use for ExternalData support. So.. unless someone comes and say that this particular mask is in use at some place (which I could not find), I will update the external data PR too!
chakrabot
pushed a commit
that referenced
this pull request
Jan 31, 2018
…e under TypeFlagMask Merge pull request #3717 from obastemur:rem_inter CanHaveInterceptors was being triggered heavily on some of the benchmarks and looking deeper shown that there is no reason keeping this code around. Besides.. Removing this, comes with a very useful space within `TypeFlagMask` that I could use for ExternalData support. So.. unless someone comes and say that this particular mask is in use at some place (which I could not find), I will update the external data PR too. Reminder: Both TypeFlagMask_External and TypeFlagMask_CanHaveInterceptors are set at the same place in full code. There is no place that they were being set separately.
chakrabot
pushed a commit
that referenced
this pull request
Feb 1, 2018
…d open a space under TypeFlagMask Merge pull request #3717 from obastemur:rem_inter CanHaveInterceptors was being triggered heavily on some of the benchmarks and looking deeper shown that there is no reason keeping this code around. Besides.. Removing this, comes with a very useful space within `TypeFlagMask` that I could use for ExternalData support. So.. unless someone comes and say that this particular mask is in use at some place (which I could not find), I will update the external data PR too. Reminder: Both TypeFlagMask_External and TypeFlagMask_CanHaveInterceptors are set at the same place in full code. There is no place that they were being set separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CanHaveInterceptors was being triggered heavily on some of the benchmarks and looking deeper shown that there is no reason keeping this code around.
Besides.. Removing this, comes with a very useful space within
TypeFlagMaskthat I could use for ExternalData support.So.. unless someone comes and say that this particular mask is in use at some place (which I could not find), I will update the external data PR too.
Reminder: Both TypeFlagMask_External and TypeFlagMask_CanHaveInterceptors are set at the same place in full code. There is no place that they were being set separately.