Skip to content

Do not install chainer>=7.0.0 in python2#8517

Merged
mergify[bot] merged 2 commits intochainer:masterfrom
knorth55:release-python2
Jan 9, 2020
Merged

Do not install chainer>=7.0.0 in python2#8517
mergify[bot] merged 2 commits intochainer:masterfrom
knorth55:release-python2

Conversation

@knorth55
Copy link
Copy Markdown
Contributor

@knorth55 knorth55 commented Dec 16, 2019 •
edited
Loading

I don't know why, but chainer>=7.0.0 is released in python2.
This PR stops installing chainer>=7.0.0 in python2.
chainer>=7.0.0 includes type hint in #8248, which breaks backward compatibility in python 2.
Documentation says Chainer drops python 2 support, so there is no need to release chainer>=7.0.0 in python2.

I also want to stop releasing chainer>=7.0.0 because python2 is unfortunately system python for Ubuntu 16.04, 18.04.
There are several people who are forced to use Python2 in this age.
I want to do releasing like matplotlib, but I don't have enough knowledge about releasing.

@knorth55 knorth55 mentioned this pull request Dec 16, 2019
Closed
@kmaehashi kmaehashi self-assigned this Dec 17, 2019
@leofang
Copy link
Copy Markdown

leofang commented Dec 17, 2019

rel: cupy/cupy#2766

@knorth55
Copy link
Copy Markdown
Contributor Author

knorth55 commented Dec 20, 2019

any update for this issue?

@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Dec 23, 2019

pfnCI, test this please.

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 23, 2019

Jenkins CI test (for commit a2a344e, target branch master) succeeded!

kmaehashi
kmaehashi requested changes Dec 24, 2019
View reviewed changes
@kmaehashi
Copy link
Copy Markdown
Member

kmaehashi commented Dec 26, 2019

pfnCI, test this please.

@kmaehashi kmaehashi added cat:install Build and installation. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. labels Dec 26, 2019
@kmaehashi kmaehashi added this to the v7.1.0 milestone Dec 26, 2019
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 26, 2019

Jenkins CI test (for commit 801914b, target branch master) succeeded!

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Dec 29, 2019

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

2 similar comments
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Jan 2, 2020

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Jan 6, 2020

@kmaehashi This pull-request is marked as st:test-and-merge, but there were no activities for the last 3 days. Could you check?

@himkt
Copy link
Copy Markdown
Member

himkt commented Jan 9, 2020

pfnCI, test this please

@himkt himkt mentioned this pull request Jan 9, 2020
Closed
@chainer-ci
Copy link
Copy Markdown
Member

chainer-ci commented Jan 9, 2020

Jenkins CI test (for commit 801914b, target branch master) succeeded!

@mergify mergify bot merged commit be11846 into chainer:master Jan 9, 2020
@knorth55 knorth55 deleted the release-python2 branch January 9, 2020 11:21
@pazeshun pazeshun mentioned this pull request Jan 18, 2020
Merged
@knorth55 knorth55 mentioned this pull request Jan 20, 2020
Merged
@pazeshun
Copy link
Copy Markdown

pazeshun commented Jan 20, 2020 •
edited
Loading

@kmaehashi
This PR is included in chainer 7.1.0, but I think this PR should be included in chainer 7.0.0.
In default, chainer 7.0.0 is still installed on Python 2, because that version doesn't have this PR:

$ python --version
Python 2.7.12
$ pip install --user chainer -U --no-cache-dir
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/__init__.py:83: RequestsDependencyWarning: Old version of cryptography ([1, 2, 3]) may cause slowdown.
  warnings.warn(warning, RequestsDependencyWarning)
DEPRECATION: Python 2.7 will reach the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 won't be maintained after that date. A future version of pip will drop support for Python 2.7. More details about Python 2 support in pip, can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support
Collecting chainer
  Downloading https://files.pythonhosted.org/packages/a8/ba/32b704e077cb24b4d85260512a5af903e772f06fb58e716301dd51758869/chainer-7.0.0.tar.gz (1.0MB)
     |████████████████████████████████| 1.0MB 6.8MB/s 
Requirement already satisfied, skipping upgrade: setuptools in /usr/lib/python2.7/dist-packages (from chainer) (20.7.0)
Requirement already satisfied, skipping upgrade: typing_extensions in /usr/local/lib/python2.7/dist-packages (from chainer) (3.6.6)
Requirement already satisfied, skipping upgrade: filelock in /usr/local/lib/python2.7/dist-packages (from chainer) (3.0.12)
Requirement already satisfied, skipping upgrade: numpy>=1.9.0 in /usr/lib/python2.7/dist-packages (from chainer) (1.11.0)
Requirement already satisfied, skipping upgrade: protobuf>=3.0.0 in /usr/local/lib/python2.7/dist-packages (from chainer) (3.7.1)
Requirement already satisfied, skipping upgrade: six>=1.9.0 in /usr/local/lib/python2.7/dist-packages (from chainer) (1.12.0)
Requirement already satisfied, skipping upgrade: typing>=3.6.2 in /usr/local/lib/python2.7/dist-packages (from typing_extensions->chainer) (3.6.6)
Building wheels for collected packages: chainer
  Building wheel for chainer (setup.py) ... done
  Created wheel for chainer: filename=chainer-7.0.0-cp27-none-any.whl size=966689 sha256=6726de9d2a99a80a072881cc91db5ea64f26132746b670f71363ec8a843b57ad
  Stored in directory: /tmp/pip-ephem-wheel-cache-t0HWQm/wheels/42/ab/c8/d723d9d7a08b5649c7343f113e74c729d4a1bd5d96e349294b
Successfully built chainer
Installing collected packages: chainer
Successfully installed chainer-7.0.0
WARNING: You are using pip version 19.2.3, however version 19.3.1 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

Is it possible to re-relase chainer 7.0.0 including this PR or stop releasing chainer 7.0.0?
Otherwise, Python 2 compatible version (6.7.0?) should be released as version newer than 7.0.0...

@pfn-ci-bot

This comment has been minimized.

Sign in to view
@pfn-ci-bot

This comment has been minimized.

Sign in to view
@knorth55
Copy link
Copy Markdown
Contributor Author

knorth55 commented Jan 21, 2020 •
edited
Loading

I'm for @pazeshun 's idea.
pip2 still installs chainer==7.0.0 because chainer==7.0.0 is not overwritten.

@toslunar toslunar mentioned this pull request Feb 7, 2020
Merged
@knorth55
Copy link
Copy Markdown
Contributor Author

knorth55 commented Feb 10, 2020

@pazeshun
What is the status of the issue that pip2 installs chainer=7.0.0?
Should we open another issue?

@pazeshun
Copy link
Copy Markdown

pazeshun commented Feb 11, 2020

@knorth55
Status is not changed. pip2 installs chainer 7.0.0.
And I understood that released version cannot be overwritten...
https://stackoverflow.com/questions/21064581/how-to-overwrite-pypi-package-when-doing-upload-from-command-line
I found that specified version may be able to be removed, though it is a drastic change:
https://stackoverflow.com/questions/20403387/how-to-remove-a-package-from-pypi

@pazeshun pazeshun mentioned this pull request Feb 11, 2020
Closed
@pazeshun
Copy link
Copy Markdown

pazeshun commented Feb 11, 2020

Should we open another issue?

I created #8545

@pazeshun pazeshun mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kmaehashi kmaehashi kmaehashi approved these changes

Assignees

@kmaehashi kmaehashi

Labels

cat:install Build and installation. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes.

Projects

None yet

Milestone

v7.1.0

Development

Successfully merging this pull request may close these issues.

7 participants

@knorth55 @leofang @kmaehashi @chainer-ci @himkt @pazeshun @pfn-ci-bot