Fix deadlock on MultiprocessIterator and MultiprocessParallelUpdater#7511
Merged
mergify[bot] merged 1 commit intochainer:masterfrom Sep 12, 2019
Merged
Conversation
hvy
reviewed
Jun 14, 2019
e4bbfae to
88def02
Compare
This was referenced Jun 14, 2019
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs. Thank you for your contributions. |
Member
|
I'm sorry for delay. Jenkins, test this please |
Member
|
Jenkins CI test (for commit 2fffa50, target branch master) succeeded! |
Member
|
@mergify[bot] This pull-request is marked as |
niboshi
pushed a commit
to niboshi/chainer
that referenced
this pull request
Sep 16, 2019
Fix deadlock on MultiprocessIterator and MultiprocessParallelUpdater
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using MultiprocessIterator in conjunction with MultiprocessParallelUpdater
The iterators are not finalized on MultiprocessParallelUpdater.finalize method.
The iterator state is cleanup while the python process exits and the iterator internal state is now inconsistent. The iterator uses an internal thread that gets stuck and tries to perpetually join it
deadlocking the execution.