Skip to content

Revert "Allows writing lint-friendly tests"#306

Merged
keithamus merged 1 commit intomasterfrom
revert-297-noopchainfunc
Nov 13, 2014
Merged

Revert "Allows writing lint-friendly tests"#306
keithamus merged 1 commit intomasterfrom
revert-297-noopchainfunc

Conversation

@keithamus
Copy link
Copy Markdown
Member

@keithamus keithamus commented Nov 13, 2014

@logicalparadox
Copy link
Copy Markdown
Member

logicalparadox commented Nov 13, 2014

👍

@keithamus
Copy link
Copy Markdown
Member Author

keithamus commented Nov 13, 2014

😦

keithamus added a commit that referenced this pull request Nov 13, 2014
@keithamus
Merge pull request #306 from chaijs/revert-297-noopchainfunc
b71b930 
Revert "Allows writing lint-friendly tests"
@keithamus keithamus merged commit b71b930 into master Nov 13, 2014
@keithamus keithamus deleted the revert-297-noopchainfunc branch November 13, 2014 14:39
@keithamus
Copy link
Copy Markdown
Member Author

keithamus commented Nov 13, 2014

Perhaps a 1.10.1/1.11.0 release?

@keithamus keithamus mentioned this pull request Dec 2, 2014
Closed
@keithamus keithamus mentioned this pull request Dec 10, 2014
Closed
@benmosher benmosher mentioned this pull request Dec 17, 2014
Closed
@joshperry
Copy link
Copy Markdown
Contributor

joshperry commented Jan 9, 2015

Just wonder if you guys are going to revert this or just leave it until people start to use the new syntax in their code... The chaijs website was also updated to document this new syntax. If we wait too long, reverting may end up being a backcompat issue.

@keithamus
Copy link
Copy Markdown
Member Author

keithamus commented Jan 10, 2015

@joshperry indeed. master has been reverted we just need to cut a new release - which is dependant on #337

This was referenced Feb 6, 2015
Closed
Merged
@rwjblue rwjblue mentioned this pull request Feb 7, 2015
Closed
@johanneswuerbach
Copy link
Copy Markdown

johanneswuerbach commented Feb 7, 2015

I think this change should be published asap (and marked as breaking) as it is advertised for ~ 2 months on your homepage and we (and I think others) already converted our projects to the new syntax.

@keithamus
Copy link
Copy Markdown
Member Author

keithamus commented Feb 7, 2015

Yes, you're very right @johanneswuerbach. I'm going to work on getting a release out as soon as I can.

@keithamus keithamus mentioned this pull request Feb 12, 2015
Closed
@keithamus keithamus mentioned this pull request Feb 19, 2015
Closed
koulmomo added a commit to yahoo/fluxible-action-utils that referenced this pull request Feb 26, 2015
@koulmomo
⬆️ bump chai devdep to ^2.0
90e5ec1 
modify unit tests due to breaking changes from chai 1.10 -> 2.0
chaijs/chai#308
chaijs/chai#306
@koulmomo koulmomo mentioned this pull request Feb 26, 2015
Merged
@keithamus keithamus mentioned this pull request Mar 23, 2015
Closed
@solsson solsson mentioned this pull request May 6, 2015
Closed
@sankethkatta
Copy link
Copy Markdown

sankethkatta commented Oct 23, 2015

@paul-barry-kenzan I was wondering the same thing. There seems to be some more context here: #371 (comment)

@keithamus keithamus mentioned this pull request Nov 9, 2015
Closed
This was referenced Nov 24, 2015
Closed
Closed
@meeber meeber mentioned this pull request Apr 25, 2016
Closed
@renovate renovate bot mentioned this pull request Feb 2, 2018
Closed
@MitMaro MitMaro mentioned this pull request Sep 3, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@keithamus @logicalparadox @joshperry @johanneswuerbach @sankethkatta @walterpinson @paul-barry-kenzan @meeber