Configuration File Update w/o Certificate Issuance#9355
Conversation
alexzorin
left a comment
There was a problem hiding this comment.
The latest set of changes look good!
I think we'll need to stick # pylint: disable=too-many-lines at the top of storage.py.
There was a problem hiding this comment.
Besides the error message about modifying domains on the certificate, this feels pretty finished!
I had suggested two things earlier:
- An integration test that uses the
reconfigureverb, just so we remain really sure that it really works. - Documenting the usage of this verb in the user guide. (I am 100% behind punting this to a follow-up PR though).
Also, master will need to be merged for CHANGELOG.
| if config.domains: | ||
| raise errors.ConfigurationError("You have specified domains, but this function cannot " | ||
| "be used to modify the domains in a certificate. If you would like to do so, follow " | ||
| "the instructions at https://certbot.org/change-cert-domain. Otherwise, remove the " |
There was a problem hiding this comment.
link does not yet exist, do not merge!
There was a problem hiding this comment.
The link seems to have appeared today, let's merge! 🎉
Updated the message; waiting for shortlink to be created. I don't think it will interfere with any documentation changes, but we can always update the link location if needed.
Added a simple test for adding and updating, though I kept it basic since the unit tests are in fact updating the configuration file as well.
Created #9531
Done |
Fixes #8822
This PR allows a user to modify the configuration of a certificate without renewing it. This can be used to add or modify hooks, change the authenticator, or modify other renewal options. It will attempt a dry run in the process to verify that the new options work.
Also creates a
reconfigurehelp section: