Remove python_version setting from mypy.ini#8426
Merged
ohemorange merged 11 commits intomasterfrom Nov 5, 2020
Merged
Conversation
atombrella
pushed a commit
to atombrella/certbot
that referenced
this pull request
Nov 12, 2020
* Remove python_version from mypy.ini. * Fix magic_typing * Ignore msvcrt usage. * make mypy happier * clean up changes * Add type for reporter queue * More mypy fixes * Fix pyrfc3339 str. * Remove unused import. * Make certbot.util mypy work in both Pythons * Fix typo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7806.
This is needed to unblock #8134 as described at #8134 (comment).
One change in this PR which isn't ideal is disabling the type checking on
msvcrtinlock.py. As said in the comment, this is fixed in newer versions ofmypyso I tried to upgrademypyto fix it but it's a fair bit of work. Instead, I opened #8425 to track that as part of our planned mypy work in a few months.