Add an option to dns_rfc2136 plugin to specify an authorative base domain.#7029
Merged
adferrand merged 6 commits intocertbot:masterfrom May 16, 2019
Merged
Add an option to dns_rfc2136 plugin to specify an authorative base domain.#7029adferrand merged 6 commits intocertbot:masterfrom
adferrand merged 6 commits intocertbot:masterfrom
Conversation
adferrand
requested changes
May 8, 2019
Collaborator
adferrand
left a comment
There was a problem hiding this comment.
Only some little improvements on the code comments, otherwise LGTM!
Contributor
Author
|
@adferrand I changed the comments according to your remarks. Would be great if you could have a look at it. |
Collaborator
|
Yes of course, all good for me now! |
adferrand
approved these changes
May 16, 2019
Collaborator
|
Oups forgot one thing, really sorry about that: could you make one other PR to add I will merge your new PR right after. |
Contributor
Author
|
Yes sure, no problem. |
ohemorange
pushed a commit
that referenced
this pull request
Jun 10, 2019
bmw
added a commit
that referenced
this pull request
Jun 10, 2019
ohemorange
pushed a commit
that referenced
this pull request
Jun 10, 2019
ohemorange
pushed a commit
that referenced
this pull request
Jun 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added an option to dns_rfc2136 plugin to explicitly specify the base domain for which the DNS server is authorative. This solves problems with split horizon DNS configurations which do not correctly report authorative SOA records when queried without a TSIG key. Could be useful for other use cases.