Implement POST-as-GET requests#6522
Merged
ohemorange merged 12 commits intocertbot:masterfrom Nov 30, 2018
Merged
Conversation
8a163f8 to
44e3824
Compare
44e3824 to
28dde9a
Compare
3eb6f87 to
9f94ebd
Compare
adferrand
pushed a commit
to adferrand/certbot
that referenced
this pull request
Nov 22, 2018
ohemorange
requested changes
Nov 28, 2018
Contributor
ohemorange
left a comment
There was a problem hiding this comment.
The design for acme/acme/client.py, which I should really just write up and stick at the top, is that ClientBase is strictly for things that are identical under both v1 and v2. Comments on how to do that inline.
Larger question: why is Pebble integration in this PR? Were you using it to test against by commenting out parts of certbot-boulder-integration? If we're going to include it, let's put something helpful there, like some test that does run properly.
ohemorange
requested changes
Nov 29, 2018
ohemorange
approved these changes
Nov 30, 2018
adferrand
pushed a commit
to adferrand/certbot
that referenced
this pull request
Nov 30, 2018
…uilding." This reverts commit a36d65c.
ohemorange
added a commit
that referenced
this pull request
Nov 30, 2018
This reverts commit 0b5468e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: #6452
This PR implements POST-as-GET requests for ACME v2 protocol.
With ACME v1, GET requests will be used directly. Furthermore with ACME v2, a GET request will be used if POST-as-GET failed, to handle gracefully ACME CA servers that do not implement yet the new ACME specification.
Also this PR adds scripts to execute the tests against Pepple, the integration ACME CA server of Let'sEncrypt for new features. Nothing is added to the CI yet, as the tests will fail because tls-sni-01 challenges are not accepted anymore by Pebble. But maybe in a future request, with adapted integration tests that would be also translated into Python.
cc @bmw @ohemorange