Skip to content

Add the "life of a certificate" diagram#582

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:add-diagram
Jul 9, 2021
Merged

Add the "life of a certificate" diagram#582
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:add-diagram

Conversation

@maelvls
Copy link
Copy Markdown
Member

@maelvls maelvls commented Jun 3, 2021 •
edited
Loading

This PR is part of the work in #426. This diagram is not done, but I propose to release an initial version instead of waiting further.

Preview https://deploy-preview-582--cert-manager.netlify.app/docs/concepts/certificate/

cc @irbekrm

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 3, 2021
@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jun 3, 2021

Looks great to me already 🥳 🥳

(I think the correct preview link might be https://deploy-preview-582--cert-manager.netlify.app/docs/concepts/certificate/)

A small nit- I think the Order is not removed immediately, but just by the time the next Order needs to be created?

Suggestion: 'requestmanager creates CertificateRequest with revision = "1" since its revision is nil' <- perhaps it would make sense to drop the 'since its revision is nil', I imagine it would be either obvious or confusing?

Another suggestion: I think the Challenges are created from Order.status.authorizations fields, perhaps worth to move the arrows slightly to indicate this?

Agree that it might make sense to merge this as is though and I think the diagram is great- it should be super helpful to users already.
Please unhold to merge as is if you'd rather do that!

/hold
/approve
/lgtm

@jetstack-bot jetstack-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2021
@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2021
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jun 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irbekrm, maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maelvls
Copy link
Copy Markdown
Member Author

maelvls commented Jun 7, 2021

/test pull-cert-manager-website-verify

@maelvls
concepts/certificate: add the "life of a certificate" diagram
967f38a 
Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@maelvls
Copy link
Copy Markdown
Member Author

maelvls commented Jul 9, 2021

poke @irbekrm

@irbekrm
Copy link
Copy Markdown
Contributor

irbekrm commented Jul 9, 2021

Thanks for the poke 😄

I think we should merge this, it would give users a lot of value imo.

Thank you for working on this and making it so nice!

/lgtm

/hold cancel

@jetstack-bot jetstack-bot added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 9, 2021
@jetstack-bot jetstack-bot merged commit 7613ed4 into cert-manager:master Jul 9, 2021
@jetstack-bot jetstack-bot mentioned this pull request Aug 11, 2021
Merged
@maelvls maelvls deleted the add-diagram branch September 7, 2023 07:32
maelvls added a commit to maelvls/website that referenced this pull request Sep 7, 2023
@maelvls
concept/certificate: add the source of the PNG
df3dc76 
I forgot to add the source in [1]. Or rather, I had embedded the source
inside the PNG file, which is surprising to anyone who wants to make
changes to the diagram. As I explained in [2], let's have the source
directly checked in Git.

[1]: cert-manager#582
[2]: cert-manager#426

Signed-off-by: Maël Valais <mael@vls.dev>
@maelvls maelvls mentioned this pull request Sep 7, 2023
Merged
Nickmman pushed a commit to Nickmman/cert-manager-website that referenced this pull request Sep 18, 2023
@maelvls @Nickmman
concept/certificate: add the source of the PNG
4e55c8c 
I forgot to add the source in [1]. Or rather, I had embedded the source
inside the PNG file, which is surprising to anyone who wants to make
changes to the diagram. As I explained in [2], let's have the source
directly checked in Git.

[1]: cert-manager#582
[2]: cert-manager#426

Signed-off-by: Maël Valais <mael@vls.dev>
SgtCoDFish pushed a commit to SgtCoDFish/cert-manager-website that referenced this pull request Jan 18, 2024
@maelvls @SgtCoDFish
concept/certificate: add the source of the PNG
b07bb59 
I forgot to add the source in [1]. Or rather, I had embedded the source
inside the PNG file, which is surprising to anyone who wants to make
changes to the diagram. As I explained in [2], let's have the source
directly checked in Git.

[1]: cert-manager#582
[2]: cert-manager#426

Signed-off-by: Maël Valais <mael@vls.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@irbekrm irbekrm

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maelvls @irbekrm @jetstack-bot