Skip to content

Adding spacing to render bulleted list correctly#362

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
komish:fix-bullet-spacing
Nov 10, 2020
Merged

Adding spacing to render bulleted list correctly#362
jetstack-bot merged 1 commit intocert-manager:masterfrom
komish:fix-bullet-spacing

Conversation

@komish
Copy link
Copy Markdown
Contributor

@komish komish commented Nov 9, 2020 •
edited
Loading

Small change! Just noticed that content modified in this PR was structured as a bulleted list but didn't appear as one in the rendered version of the documentation (It does render correctly in VSCode's markdown preview, though).

Where is this happening today:

Signed-off-by: Jose R. Gonzalez josegonzalez89@gmail.com

@komish
adding spacing to render bulleted list correctly
3a1d3c0 
Signed-off-by: Jose R. Gonzalez <josegonzalez89@gmail.com>
@jetstack-bot jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 9, 2020
@jetstack-bot jetstack-bot requested a review from jakexks November 9, 2020 17:12
@jetstack-bot jetstack-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 9, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Nov 9, 2020

Hi @komish. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2020
@jakexks
Copy link
Copy Markdown
Member

jakexks commented Nov 10, 2020

/ok-to-test
/approve
/lgtm

@jetstack-bot jetstack-bot added ok-to-test lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 10, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Nov 10, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, komish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2020
@jetstack-bot jetstack-bot merged commit 2cc8028 into cert-manager:master Nov 10, 2020
@jetstack-bot jetstack-bot added this to the v1.0 milestone Nov 10, 2020
@komish komish deleted the fix-bullet-spacing branch November 10, 2020 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakexks jakexks Awaiting requested review from jakexks

Assignees

@jakexks jakexks

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@komish @jetstack-bot @jakexks