Skip to content

Document how to configure Venafi TPP access-token authentication#346

Merged
jetstack-bot merged 5 commits intocert-manager:release-nextfrom
wallrj:3140-tpp-access-token
Nov 17, 2020
Merged

Document how to configure Venafi TPP access-token authentication#346
jetstack-bot merged 5 commits intocert-manager:release-nextfrom
wallrj:3140-tpp-access-token

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Oct 8, 2020

@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Oct 8, 2020
@jetstack-bot jetstack-bot requested a review from munnerz October 8, 2020 09:22
@jetstack-bot jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2020
@wallrj wallrj marked this pull request as draft October 8, 2020 09:22
munnerz
munnerz reviewed Oct 8, 2020
View reviewed changes
@jetstack-bot jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 13, 2020
@wallrj wallrj mentioned this pull request Oct 14, 2020
Merged
komish and others added 4 commits November 9, 2020 11:07
@komish
adding spacing to render bulleted list correctly
3a1d3c0 
Signed-off-by: Jose R. Gonzalez <josegonzalez89@gmail.com>
@jetstack-bot
Merge pull request cert-manager#362 from komish/fix-bullet-spacing
2cc8028 
Adding spacing to render bulleted list correctly
@meyskens
Use the GUID zone for venafi Cloud example
c5f52ce 
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot
Merge pull request cert-manager#364 from meyskens/update-vcloud-example
f8bf765 
Use the GUID zone for venafi Cloud example
@wallrj wallrj force-pushed the 3140-tpp-access-token branch from 64c10ea to 4e85eab Compare November 11, 2020 13:24
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2020
@wallrj wallrj changed the title WIP: Document how to set up Venafi TPP token authentication Document how to configure Venafi TPP access-token authentication Nov 11, 2020
@wallrj wallrj marked this pull request as ready for review November 11, 2020 13:25
@jetstack-bot jetstack-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 11, 2020
@wallrj
Document how to set up access-token authentication
d37cd0b 
Signed-off-by: Richard Wall <richard.wall@jetstack.io>
@wallrj wallrj force-pushed the 3140-tpp-access-token branch from 4e85eab to d37cd0b Compare November 11, 2020 13:42
@meyskens meyskens changed the base branch from master to release-next November 17, 2020 14:28
@jetstack-bot jetstack-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 17, 2020
@meyskens meyskens added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Nov 17, 2020
@meyskens
Copy link
Copy Markdown
Contributor

meyskens commented Nov 17, 2020

/approve
/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Nov 17, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: meyskens, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 17, 2020
@jetstack-bot jetstack-bot merged commit b56a2f3 into cert-manager:release-next Nov 17, 2020
@wallrj wallrj deleted the 3140-tpp-access-token branch February 11, 2023 16:48
@maelvls maelvls mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz munnerz left review comments

Assignees

@meyskens meyskens

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wallrj @meyskens @jetstack-bot @munnerz @komish