Use the GUID zone for venafi Cloud example#364
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Nov 11, 2020
Merged
Use the GUID zone for venafi Cloud example#364jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
wallrj
approved these changes
Nov 11, 2020
Member
wallrj
left a comment
There was a problem hiding this comment.
Thanks, I discovered this while testing against Vcloud yesterday.
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #360