[release-1.18] [VC-39805] Document the change of PrivateKeyRotationPolicy to Always#1681
Closed
wallrj wants to merge 1 commit intocert-manager:release-nextfrom
Closed
Conversation
✅ Deploy Preview for cert-manager ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
b43d120 to
2b4244f
Compare
cfb3409 to
c7999af
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates documentation to reflect the change in cert-manager v1.18 where the default Certificate.Spec.PrivateKey.RotationPolicy is now Always instead of Never. The changes update YAML examples, usage guides, and release notes to document this update.
- Updated certificate defaults and tutorials to include a note indicating the default change.
- Revised usage sections for Ingress, Gateway, and Certificate to reflect the new default behavior.
- Amended release notes and upgrade guides accordingly.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| public/docs/tutorials/certificate-defaults/cpol-mutate-certificates-1.yaml | Added an informational comment about the cert-manager version-dependent behavior for rotation policy. |
| public/docs/tutorials/certificate-defaults/cpol-mutate-certificates-0.yaml | Similar informational comment update to note that the change is unnecessary with cert-manager >=v1.18.0. |
| content/docs/usage/ingress.md | Updated default rotation policy text from Never to Always. |
| content/docs/usage/gateway.md | Updated default rotation policy text from Never to Always. |
| content/docs/usage/certificate.md | Added a detailed callout explaining the behavior change for different cert-manager versions. |
| content/docs/tutorials/certificate-defaults/README.md | Added an informational comment about the cert-manager default value change. |
| content/docs/releases/upgrading/upgrading-1.17-1.18.md | Added a note in the upgrade guide regarding the change in default rotation policy. |
| content/docs/releases/release-notes/release-notes-1.18.md | Expanded release notes to describe the breaking change in Certificate.Spec.PrivateKey.RotationPolicy. |
Files not reviewed (1)
- .spelling: Language not supported
public/docs/tutorials/certificate-defaults/cpol-mutate-certificates-1.yaml
Outdated
Show resolved
Hide resolved
public/docs/tutorials/certificate-defaults/cpol-mutate-certificates-0.yaml
Outdated
Show resolved
Hide resolved
c7999af to
d36a34e
Compare
…o Always Signed-off-by: Richard Wall <richard.wall@venafi.com>
d36a34e to
b624fa2
Compare
inteon
approved these changes
May 8, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
Author
Member
|
/approve |
wallrj
pushed a commit
to wallrj/website
that referenced
this pull request
May 13, 2025
…-key-rotation-always [release-1.18] [VC-39805] Document the change of PrivateKeyRotationPolicy to Always
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
Xref:
Alwayscert-manager#7601