Skip to content

Includes the CRL Distribution Points option#164

Merged
jetstack-bot merged 2 commits intocert-manager:release-nextfrom
skra-space:patch-1
Mar 24, 2020
Merged

Includes the CRL Distribution Points option#164
jetstack-bot merged 2 commits intocert-manager:release-nextfrom
skra-space:patch-1

Conversation

@skra-space
Copy link
Copy Markdown
Contributor

@skra-space skra-space commented Mar 20, 2020 •
edited by meyskens
Loading

EDIT:

Documentation for cert-manager/cert-manager#2625

@jetstack-bot jetstack-bot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 20, 2020
@jetstack-bot jetstack-bot added this to the v0.15 milestone Mar 20, 2020
@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 20, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 20, 2020

Hi @srbraun. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot requested a review from munnerz March 20, 2020 12:55
@jetstack-bot jetstack-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2020
@skra-space skra-space closed this Mar 20, 2020
@skra-space skra-space reopened this Mar 20, 2020
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2020
@skra-space
Includes the CRL Distribution Points option
e938927 
Signed-off-by: Sergey Braun <dev@skra.space>
meyskens
meyskens reviewed Mar 23, 2020
View reviewed changes
content/en/docs/configuration/ca.md Outdated
secretName: ca-key-pair
```

Optionally, you can specify (CRL)[https://en.wikipedia.org/wiki/Certificate_revocation_list] Distribution Points. An array of `Strings` each of which identifies the location of the CRL from which the revocation of this certificate can be checked:
Copy link
Copy Markdown
Contributor

@meyskens meyskens Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason we backtick Strings? I think just strings (with not backticks) will do in this case

Copy link
Copy Markdown
Contributor Author

@skra-space skra-space Mar 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@meyskens
Copy link
Copy Markdown
Contributor

meyskens commented Mar 23, 2020

/ok-to-test

@jetstack-bot jetstack-bot added ok-to-test dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Mar 23, 2020
@skra-space
removes backticks around strings
d324fd3 
Signed-off-by: Sergey Braun <dev@skra.space>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Mar 23, 2020
@skra-space skra-space requested a review from meyskens March 23, 2020 14:18
@munnerz munnerz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 24, 2020
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Mar 24, 2020

Thanks for putting this feature together! 😄

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Mar 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz, srbraun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@jetstack-bot jetstack-bot merged commit c5e2de1 into cert-manager:release-next Mar 24, 2020
@skra-space
Copy link
Copy Markdown
Contributor Author

skra-space commented Mar 24, 2020

Thanks for putting this feature together! smile

Thank you @munnerz for the support.

@skra-space skra-space deleted the patch-1 branch March 24, 2020 11:51
This was referenced May 6, 2020
Merged
Merged
This was referenced Feb 5, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@munnerz munnerz Awaiting requested review from munnerz

@meyskens meyskens Awaiting requested review from meyskens

Assignees

@munnerz munnerz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v0.15

Development

Successfully merging this pull request may close these issues.

4 participants

@skra-space @jetstack-bot @meyskens @munnerz