Skip to content

docs: OtherName configuration references updated#1403

Merged
jetstack-bot merged 1 commit intocert-manager:release-nextfrom
hawksight:pf/featuregate-update
Jan 31, 2024
Merged

docs: OtherName configuration references updated#1403
jetstack-bot merged 1 commit intocert-manager:release-nextfrom
hawksight:pf/featuregate-update

Conversation

@hawksight
Copy link
Copy Markdown
Member

@hawksight hawksight commented Jan 31, 2024 •
edited
Loading

Hopefully closes #1402

I copied the v1.14.0-beta.0 --help from the relevant containers into the reference docs.
And added the fields to the configuration file section too.

Not sure if there is anywhere else where is appears.

@hawksight
docs: OtherName configuration references updated
bacf3b3 
Signed-off-by: Peter Fiddes <peter.fiddes@gmail.com>
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

@hawksight: GitHub didn't allow me to request PR reviews from the following users: antstacks.

Note that only cert-manager members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

Hopefully closes #1402

I copied the v1.14.0-beta.0 --help from the relevant containers into the reference docs.
And added the fields to the configuration file section too.

Not sure if there is anywhere else where is appears.

/cc @antstacks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2024
@hawksight
Copy link
Copy Markdown
Member Author

hawksight commented Jan 31, 2024

/cc @SpectralHiss @wallrj

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 31, 2024

✅ Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit bacf3b3
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/65ba282418ea6b000844cb5d
😎 Deploy Preview https://deploy-preview-1403--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

wallrj
wallrj approved these changes Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@jetstack-bot jetstack-bot merged commit db53327 into cert-manager:release-next Jan 31, 2024
@jetstack-bot jetstack-bot mentioned this pull request Jan 31, 2024
Merged
@SpectralHiss
Copy link
Copy Markdown
Contributor

SpectralHiss commented Jan 31, 2024

/cc @SpectralHiss @wallrj

Thanks for this!!

@hawksight hawksight deleted the pf/featuregate-update branch January 31, 2024 13:07
@jetstack-bot jetstack-bot mentioned this pull request Feb 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

@SpectralHiss SpectralHiss Awaiting requested review from SpectralHiss

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hawksight @jetstack-bot @SpectralHiss @wallrj