Skip to content

Venafi Issuer: Explain why "Do not select 'refresh token enabled'"#1373

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:explain-why-refresh-not-recommended
Dec 21, 2023
Merged

Venafi Issuer: Explain why "Do not select 'refresh token enabled'"#1373
jetstack-bot merged 1 commit intocert-manager:masterfrom
maelvls:explain-why-refresh-not-recommended

Conversation

@maelvls
Copy link
Copy Markdown
Member

@maelvls maelvls commented Dec 21, 2023

A while back, when the "Access Token" authentication method was documented by Richard in #346, the following was added:

NOTE: Do not select "Refresh Token Enabled" and set a long "Token Validity (days)".

I have read a few questions about "why is cert-manager not supporting refresh tokens?", so I figured I would explain why in this PR.

Signed-off-by: Maël Valais <mael@vls.dev>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 21, 2023
@inteon inteon requested a review from wallrj December 21, 2023 09:19
@netlify
Copy link
Copy Markdown

netlify bot commented Dec 21, 2023

Deploy Preview for cert-manager-website ready!

Name Link
🔨 Latest commit 7307f0c
🔍 Latest deploy log https://app.netlify.com/sites/cert-manager-website/deploys/658402d5d0e5650008601859
😎 Deploy Preview https://deploy-preview-1373--cert-manager-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
@jetstack-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
@jetstack-bot jetstack-bot merged commit c7eee02 into cert-manager:master Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants