Explain how to install cert-manager using Flux by wallrj · Pull Request #1338 · cert-manager/website

wallrj · 2023-11-02T15:30:55Z

Preview: https://deploy-preview-1338--cert-manager-website.netlify.app/docs/installation/helm/#install-the-helm-chart-using-flux

I wanted to see for myself whether cert-manager can be installed using Flux and it seems to be quite straight forward,
so I documented it here.

I used some of the settings -- such as --crds CreateReplace -- that @slam-wowx had used in: cert-manager/cert-manager#6409.

xref:

Signed-off-by: Richard Wall <richard.wall@venafi.com>

netlify · 2023-11-02T15:34:09Z

✅ Deploy Preview for cert-manager-website ready!

Name	Link
🔨 Latest commit	`c88984a`
🔍 Latest deploy log	https://app.netlify.com/sites/cert-manager-website/deploys/6544e7c51bd8b40008082f2e
😎 Deploy Preview	https://deploy-preview-1338--cert-manager-website.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jsoref

/lgtm

content/docs/installation/helm.md

jetstack-bot · 2023-11-02T15:42:10Z

@jsoref: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>

erikgb

Added a couple of suggestions, but LGTM at it stands.

/lgtm

content/docs/installation/helm.md

jetstack-bot · 2023-11-02T17:21:37Z

@erikgb: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Added a couple of suggestions, but LGTM at it stands.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

inteon · 2023-11-02T18:25:49Z

content/docs/installation/helm.md

 discuss.

+
+## Install the Helm chart using Flux


Shouldn't we add a separate Flux section?

When I go to cert-manager.io, I probably would look for a Flux section if that is the tool I'm using.

What precisely do you propose?

I did consider adding a flux.md page, but decided that we'd end up with too many submenu items if we also add argo.md, anthos.md, octopus.md etc.

I also considered that Flux can install cert-manager in other ways too, so it seems appropriate to document the Flux Helm Controller here and in future document the Flex Kustomize controller in the kubectl applyt page.

I looked for examples from other projects and I found that Kyverno have a https://kyverno.io/docs/installation/platform-notes/ page where they include notes for ArgoCD users.
Couldn't find any other examples of projects that have a specific page for installing using flux or argo.

I have tried creating a "Continuous Deployment" page and move this tutorial there.
See what you think.

What do you think about the name "GitOps"?

I don't think it's appropriate.

GitOps is about storing your infrastructure configuration in a Git repo and then using a continuous delivery / continuous deployment like Flux tool to apply it.
So this page is about the CD part.

Why do you suggest it?

Also GitOps is the brand name Red Hat uses on their ArgoCD hybrid, so I would stay FAR away from that term. 😉

Signed-off-by: Richard Wall <richard.wall@venafi.com>

jetstack-bot · 2023-11-05T10:04:56Z

@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

/lgtm

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hawksight

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

/lgtm

jetstack-bot · 2023-11-05T10:05:38Z

@hawksight: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

I just ran through the flux installation and it worked perfectly. Thanks @wallrj - a good little intro to fluxcd for me.

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

erikgb · 2023-11-05T10:25:10Z

Just a question for anyone who knows, did fluxctl become flux instead at some point? That tripped me up as I thought I had the CLI but turns out I did not.

I think fluxctl was the CLI tool for the deprecated Flux v1 - which became flux in the current Flux v2.

inteon · 2023-11-08T04:26:55Z

/lgtm

jetstack-bot · 2023-11-08T09:29:25Z

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hawksight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Thanks for all your documentation reviews Peter, for example: * cert-manager#1344 * cert-manager#1338 * cert-manager#1331 We'd like you to be able to `lgtm` future PRs, so we're adding you to the reviewers list. Signed-off-by: Richard Wall <richard.wall@venafi.com>

Explain how to install cert-manager using Flux

0cb8376

Signed-off-by: Richard Wall <richard.wall@venafi.com>

jetstack-bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Nov 2, 2023

wallrj requested a review from hawksight November 2, 2023 15:31

jetstack-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 2, 2023

wallrj mentioned this pull request Nov 2, 2023

Helm chart version is not SemVer-compatible cert-manager/cert-manager#2380

Closed

jsoref reviewed Nov 2, 2023

View reviewed changes

content/docs/installation/helm.md Outdated Show resolved Hide resolved

Update content/docs/installation/helm.md

3bda8cb

Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Signed-off-by: Richard Wall <wallrj@users.noreply.github.com>

wallrj mentioned this pull request Nov 2, 2023

GitOps support cert-manager/cert-manager#2197

Closed

erikgb reviewed Nov 2, 2023

View reviewed changes

content/docs/installation/helm.md Outdated Show resolved Hide resolved

content/docs/installation/helm.md Outdated Show resolved Hide resolved

inteon reviewed Nov 2, 2023

View reviewed changes

wallrj added 2 commits November 3, 2023 11:15

Use the shorter .x semver range syntax

72b590e

Signed-off-by: Richard Wall <richard.wall@venafi.com>

Create a new Continuous Deployment page

c88984a

Signed-off-by: Richard Wall <richard.wall@venafi.com>

jetstack-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 3, 2023

hawksight approved these changes Nov 5, 2023

View reviewed changes

jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2023

wallrj added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2023

jetstack-bot merged commit 1c23844 into cert-manager:master Nov 8, 2023

wallrj mentioned this pull request Nov 15, 2023

Make Peter Fiddes (@hawksight) a reviewer #1346

Merged

wallrj deleted the flux-install branch November 17, 2023 14:46

jetstack-bot mentioned this pull request Dec 7, 2023

[release-next] Fast-forward master into release-next #1357

Merged

Conversation

wallrj commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Nov 2, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cert-manager-website ready!

Uh oh!

jsoref left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jetstack-bot commented Nov 2, 2023

Uh oh!

erikgb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jetstack-bot commented Nov 2, 2023

Uh oh!

inteon Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

inteon Nov 2, 2023

Choose a reason for hiding this comment

Uh oh!

wallrj Nov 3, 2023

Choose a reason for hiding this comment

Uh oh!

inteon Nov 4, 2023

Choose a reason for hiding this comment

Uh oh!

wallrj Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

erikgb Nov 7, 2023

Choose a reason for hiding this comment

Uh oh!

jetstack-bot commented Nov 5, 2023

Uh oh!

hawksight left a comment

Choose a reason for hiding this comment

Uh oh!

jetstack-bot commented Nov 5, 2023

Uh oh!

erikgb commented Nov 5, 2023

Uh oh!

inteon commented Nov 8, 2023

Uh oh!

jetstack-bot commented Nov 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wallrj commented Nov 2, 2023 •

edited

Loading

netlify bot commented Nov 2, 2023 •

edited

Loading