Skip to content

Preparing k8s v1.34 test suite#1108

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
hjoshi123:feat/k8s-1.34
Sep 13, 2025
Merged

Preparing k8s v1.34 test suite#1108
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
hjoshi123:feat/k8s-1.34

Conversation

@hjoshi123
Copy link
Copy Markdown
Contributor

@hjoshi123 hjoshi123 commented Sep 12, 2025

Adds optional tests so that we can test our CI for k8s 1.34 before making it default

@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 12, 2025
@erikgb
Copy link
Copy Markdown
Member

erikgb commented Sep 13, 2025 •
edited
Loading

@hjoshi123, I don't think you are supposed to manually edit cert-manager-master.yaml. Run make prowgen and commit the result to fix CI.

@hjoshi123
Copy link
Copy Markdown
Contributor Author

hjoshi123 commented Sep 13, 2025

Ah gotcha. Let me try that. Thank you @erikgb

@hjoshi123
preparing for 1.34 test suite
ab7507d 
Signed-off-by: hjoshi123 <hemant.joshi@vizio.com>
@cert-manager-prow cert-manager-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 13, 2025
erikgb
erikgb reviewed Sep 13, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Sep 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2025
@cert-manager-prow cert-manager-prow bot merged commit 3d3bce5 into cert-manager:master Sep 13, 2025
6 checks passed
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Sep 13, 2025

@hjoshi123: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
Details

In response to this:

Adds optional tests so that we can test our CI for k8s 1.34 before making it default

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Sep 13, 2025
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hjoshi123 @erikgb