Skip to content

Allow optional testing with Kubernetes 1.33#1096

Merged
cert-manager-prow[bot] merged 4 commits intocert-manager:masterfrom
wallrj:kubernetes-1.33
Jun 6, 2025
Merged

Allow optional testing with Kubernetes 1.33#1096
cert-manager-prow[bot] merged 4 commits intocert-manager:masterfrom
wallrj:kubernetes-1.33

Conversation

@wallrj
Copy link
Copy Markdown
Member

@wallrj wallrj commented Jun 6, 2025

This will allow me to use /test pull-cert-manager-master-e2e-v1-33 in:

If it works, I'll create another PR to add the 1.33 images to release-1.18 and make 1.33 the default version for pull requests.

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2025
As per the cert-manager.io support page:
 * https://cert-manager.io/docs/releases/#upcoming-releases

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj wallrj force-pushed the kubernetes-1.33 branch from a2e96ab to 3b9f97e Compare June 6, 2025 14:20
@wallrj wallrj changed the title WIP: Add tests for Kubernetes 1.33 and remove tests for Kubernetes 1.29, which is no longer supported Allow optional testing with Kubernetes 1.33 Jun 6, 2025
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2025
@wallrj wallrj requested a review from inteon June 6, 2025 14:25

primaryKubernetesVersion: "1.32",
otherKubernetesVersions: []string{"1.29", "1.30", "1.31"},
otherKubernetesVersions: []string{"1.29", "1.30", "1.31", "1.33"},
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"1.32" seems to be missing @wallrj

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We say we will support it here: https://cert-manager.io/docs/releases/

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's there, but in the primary Kubernetes version, for now.

If the 1.33 tests pass, I'll make those the primary.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll go ahead and merge this, and test it with cert-manager/cert-manager#7786

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! sorry for the delay

@wallrj wallrj requested a review from inteon June 6, 2025 14:46
@wallrj wallrj added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot merged commit 4bfccb4 into cert-manager:master Jun 6, 2025
6 checks passed
@cert-manager-prow
Copy link
Copy Markdown
Contributor

@wallrj: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
  • key cert-manager-release-1.18.yaml using file config/jobs/cert-manager/cert-manager/release-1.18/cert-manager-release-1.18.yaml
Details

In response to this:

This will allow me to use /test pull-cert-manager-master-e2e-v1-33 in:

If it works, I'll create another PR to add the 1.33 images to release-1.18 and make 1.33 the default version for pull requests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants