Skip to content

Update tests on master in preparation for 1.17 beta#1072

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
SgtCoDFish:update-cm-master
Jan 27, 2025
Merged

Update tests on master in preparation for 1.17 beta#1072
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
SgtCoDFish:update-cm-master

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jan 27, 2025

See cert-manager/website#1627 for details about what k8s versions cert-manager 1.17 will support.

@SgtCoDFish
update tests on master in preparation for 1.17 beta
b105578 
see cert-manager/website#1627

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 27, 2025
@ThatsMrTalbot
Copy link
Copy Markdown
Contributor

ThatsMrTalbot commented Jan 27, 2025

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2025
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 27, 2025

/approve

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jan 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SgtCoDFish, ThatsMrTalbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2025
@cert-manager-prow cert-manager-prow bot merged commit 5e90045 into cert-manager:master Jan 27, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Jan 27, 2025

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
Details

In response to this:

See cert-manager/website#1627 for details about what k8s versions cert-manager 1.17 will support.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish SgtCoDFish deleted the update-cm-master branch January 27, 2025 13:49
erikgb
erikgb reviewed Jan 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 27, 2025

Thanks both!

@SgtCoDFish SgtCoDFish mentioned this pull request Jan 27, 2025
Merged
SgtCoDFish added a commit to SgtCoDFish/cert-manager-testing that referenced this pull request Jan 27, 2025
@SgtCoDFish
fix required checks for cert-manager to match latest
8d18769 
required after cert-manager#1072

Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
@SgtCoDFish SgtCoDFish mentioned this pull request Jan 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erikgb erikgb erikgb left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SgtCoDFish @ThatsMrTalbot @erikgb