Skip to content

Update tested k8s versions to roughly match latest supported releases#1059

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
SgtCoDFish:supported-k8s
Sep 25, 2024
Merged

Update tested k8s versions to roughly match latest supported releases#1059
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
SgtCoDFish:supported-k8s

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Sep 25, 2024

See cert-manager/website#1563 for the latest changes.

This doesn't add testing for k8s 1.31 against cert-manager 1.15, 1.14 or 1.12

  • For 1.15, futher changes are needed in upstream cert-manager to enable testing 1.31
  • For 1.14, it'll be EOL in a couple of weeks so we'll probably just ignore 1.31 there.
  • For 1.12, see the comment I wrote; I don't want to tackle testing both 1.22 and 1.31 in this PR (maybe we won't ever tackle it)

@SgtCoDFish
update tested k8s versions to roughly match latest supported releases
5fe739c 
See cert-manager/website#1563 for the latest
changes.

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 25, 2024
inteon
inteon reviewed Sep 25, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2024
@cert-manager-prow cert-manager-prow bot merged commit bbcbda2 into cert-manager:master Sep 25, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Sep 25, 2024

@SgtCoDFish: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key cert-manager-master.yaml using file config/jobs/cert-manager/cert-manager/master/cert-manager-master.yaml
Details

In response to this:

See cert-manager/website#1563 for the latest changes.

This doesn't add testing for k8s 1.31 against cert-manager 1.15, 1.14 or 1.12

  • For 1.15, futher changes are needed in upstream cert-manager to enable testing 1.31
  • For 1.14, it'll be EOL in a couple of weeks so we'll probably just ignore 1.31 there.
  • For 1.12, see the comment I wrote; I don't want to tackle testing both 1.22 and 1.31 in this PR (maybe we won't ever tackle it)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@SgtCoDFish SgtCoDFish deleted the supported-k8s branch September 25, 2024 14:07
This was referenced Sep 25, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon inteon left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SgtCoDFish @inteon