Skip to content

added affinity and tolerations#869

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
gintautassulskus:affinity-and-tolerations
Sep 6, 2018
Merged

added affinity and tolerations#869
jetstack-bot merged 2 commits intocert-manager:masterfrom
gintautassulskus:affinity-and-tolerations

Conversation

@gintautassulskus
Copy link
Copy Markdown
Contributor

@gintautassulskus gintautassulskus commented Sep 5, 2018

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Sep 5, 2018

@gintautassulskus: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 5, 2018
@jetstack-bot jetstack-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 5, 2018
@gintautassulskus gintautassulskus mentioned this pull request Sep 5, 2018
Closed
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Sep 5, 2018

/ok-to-test

@jetstack-bot jetstack-bot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2018
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Sep 5, 2018

Thanks very much!

You'll also need to run ./hack/update-deploy-gen.sh in order to regenerate our 'static' deployment manifests. This basically runs helm template with some presets, so that we can publish a non-helm installation method for users that don't want to use Helm!

@munnerz
Copy link
Copy Markdown
Member

munnerz commented Sep 6, 2018

Hey @gintautassulskus - this looks good to go to me!

In order to accept contributions here, we require commits have a 'DCO signoff' on them. Would you be able to follow the instructions in the contributor guide on how to do this?

Basically it involves something like git rebase --signoff master - this will add an extra line to the end of all your commit messages, and appease the bots 😄

I'll then be able to merge this in and get then get it synced across to the helm/charts repo!

@gintautassulskus
added affinity and tolerations
6a6268c 
Signed-off-by: Gintautas Sulskus <gintautas.sulskus@gmail.com>
@gintautassulskus
generated static deployemnt manifests
7a39753 
Signed-off-by: Gintautas Sulskus <gintautas.sulskus@gmail.com>
@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 6, 2018
@gintautassulskus
Copy link
Copy Markdown
Contributor Author

gintautassulskus commented Sep 6, 2018

Thanks, @munnerz, for the guidance! It has been quite a quest to merge these changes :D

@munnerz
Copy link
Copy Markdown
Member

munnerz commented Sep 6, 2018

/lgtm
/approve

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2018
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Sep 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: munnerz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2018
@munnerz
Copy link
Copy Markdown
Member

munnerz commented Sep 6, 2018

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 6, 2018
@jetstack-bot jetstack-bot merged commit 3945595 into cert-manager:master Sep 6, 2018
@munnerz munnerz mentioned this pull request Sep 10, 2018
Merged
munnerz added a commit to munnerz/charts-1 that referenced this pull request Sep 10, 2018
@munnerz
cert-manager: fast-forward to upstream bcffc635
e058fde 
* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>
k8s-ci-robot pushed a commit to helm/charts that referenced this pull request Sep 13, 2018
@munnerz @k8s-ci-robot
cert-manager: fast-forward to upstream 3945595b (#7644)
e0505bb 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
jicowan pushed a commit to jicowan/charts that referenced this pull request Oct 2, 2018
@munnerz @jicowan
cert-manager: fast-forward to upstream 3945595b (helm#7644)
2b1a940 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: jenkin-x <jicowan@hotmail.com>
Jnig pushed a commit to Jnig/charts that referenced this pull request Nov 13, 2018
@munnerz @Jnig
cert-manager: fast-forward to upstream 3945595b (helm#7644)
42fb445 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
Signed-off-by: Jakob Niggel <info@jakobniggel.de>
wgiddens pushed a commit to wgiddens/charts that referenced this pull request Jan 18, 2019
@munnerz @wgiddens
cert-manager: fast-forward to upstream 3945595b (helm#7644)
1100fa3 
* cert-manager: fast-forward to upstream bcffc635

* Update version numbers for v0.5.0 (cert-manager/cert-manager#885)
* added affinity and tolerations (cert-manager/cert-manager#869)
* Add validating webhook and webhook tls autoconfiguration (cert-manager/cert-manager#478)
* chart: annotate all CRDs with "crd-install" hook (cert-manager/cert-manager#823)
* helm chart: remove endpoints from rbac resources (cert-manager/cert-manager#769)

Signed-off-by: James Munnelly <james@munnelly.eu>

* Update image tag and add description

Signed-off-by: James Munnelly <james@munnelly.eu>
@wallrj
Copy link
Copy Markdown
Member

wallrj commented Oct 23, 2023

@gintautassulskus I have drafted some documentation for the cert-manager website.
If you have time, please take a look and give feedback:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simonswine simonswine Awaiting requested review from simonswine

Assignees

@munnerz munnerz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gintautassulskus @jetstack-bot @munnerz @wallrj