fix(certificate-shim): removing duplicate parentRefs#8619
Merged
cert-manager-prow[bot] merged 1 commit intoMar 20, 2026
Merged
Conversation
Collaborator
Author
|
/cc @maelvls |
701edce to
7e90655
Compare
Signed-off-by: hjoshi123 <mail@hjoshi.me> Signed-off-by: Hemant Joshi <mail@hjoshi.me>
7e90655 to
8d6c1c8
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rohansood10
added a commit
to rohansood10/cert-manager
that referenced
this pull request
Mar 20, 2026
When a Gateway has multiple listeners (e.g., HTTP and HTTPS), the ACME HTTP-01 solver's HTTPRoute could end up with multiple parentRefs targeting the same Gateway without sectionName set. Gateway API v1.5.0 (used in cert-manager 1.20.0) now enforces that sectionName must be specified when there are 2+ parentRefs to the same parent, causing solver HTTPRoute creation to fail in an infinite error loop. The root cause deduplication in applyGatewayAPIAnnotationParentRefOverride was addressed in cert-manager#8619. This commit adds a defense-in-depth deduplicateParentRefs() call in generateHTTPRouteSpec to catch any remaining duplicate parentRefs that might slip through other code paths, along with additional test coverage for the annotation-override deduplication behavior. Fixes cert-manager#8611 Signed-off-by: Rohan Sood <56945243+rohansood10@users.noreply.github.com>
Member
|
/cherry-pick release-1.20 |
Contributor
|
@maelvls: new pull request created: #8658 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
Adding extra validation so that we dont duplicate parentRefs from issuer config with the annotations on the cert object.
Kind
/kind bug
Release Note