Skip to content

fix(ci): upgrading to v1.34 for CI and local tests#8073

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
hjoshi123:feat/upgrade-k8s-1.34
Sep 13, 2025
Merged

fix(ci): upgrading to v1.34 for CI and local tests#8073
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
hjoshi123:feat/upgrade-k8s-1.34

Conversation

@hjoshi123
Copy link
Copy Markdown
Collaborator

Pull Request Motivation

Upgrading our tests and local infra of kind to 1.34. As part of this already created custom jobs to test on 1.34 by adding the config here cert-manager/testing#1108. Once this works we can make this the default for testing.

Kind

/kind cleanup

Release Note

NONE

@cert-manager-prow cert-manager-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 13, 2025
@hjoshi123
Copy link
Copy Markdown
Collaborator Author

/test pull-cert-manager-master-e2e-v1-34

@erikgb
Copy link
Copy Markdown
Member

erikgb commented Sep 13, 2025

Should we create an issue to see if we can make Renovate fix this, @hjoshi123?

@hjoshi123
Copy link
Copy Markdown
Collaborator Author

Should we create an issue to see if we can make Renovate fix this, @hjoshi123?

Ah yes that's a good idea actually. We do this every 3-4 months if renovate could this would reduce a lot of toil. I will create one. Thank you for suggesting this.

Signed-off-by: hjoshi123 <mail@hjoshi.me>
@hjoshi123 hjoshi123 force-pushed the feat/upgrade-k8s-1.34 branch from 7cab869 to 4eefe4f Compare September 13, 2025 17:35
@hjoshi123
Copy link
Copy Markdown
Collaborator Author

/test pull-cert-manager-master-e2e-v1-34

Copy link
Copy Markdown
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hjoshi123! 🚀

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2025
@cert-manager-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2025
@cert-manager-prow cert-manager-prow bot merged commit a06d6c3 into cert-manager:master Sep 13, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants