feat: log version information when starting the cert-manager controller, webhook and ca-injector by prasad89 · Pull Request #8072 · cert-manager/cert-manager

prasad89 · 2025-09-13T10:21:07Z

Pull Request Motivation

Print util.AppVersion and util.AppGitCommit when the controller, webhook and ca-injector starts.
Previously, these values were present in Short, which never gets printed for the root command removed since they are standalone root commands with no subcommands.
resolves #8067

Kind

/kind feature

Release Note

The controller, webhook and ca-injector now log their version and git commit on startup for easier debugging and support.

CyberArk tracker: VC-45229

cert-manager-prow · 2025-09-13T10:21:17Z

Hi @prasad89. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

Copilot

Pull Request Overview

This PR adds version information logging when the cert-manager controller starts up. The change improves debugging and support capabilities by making version details visible in controller logs.

Adds logging of version, git commit, Go version, and platform information at controller startup
Imports the util package to access version information functions

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

erikgb · 2025-09-13T14:32:25Z

/ok-to-test

erikgb

Thanks @prasad89! Can you please also fix webhook and ca-injector, which has the same issue. I wonder if we can just remove the Cobra Short description on these root commands, as they are never shown anyway. AFAIK, none of these commands have sub-commands. Correct, @maelvls?

prasad89 · 2025-09-15T05:40:48Z

Thanks for the review, @erikgb.

You're correct none of these commands call AddCommand(), which confirms they are standalone root commands with no subcommands. As a result, their Short descriptions are never shown to users.

Should we go ahead and remove the Short descriptions from all three commands (controller, webhook, and ca-injector)?

erikgb · 2025-09-15T06:27:17Z

Should we go ahead and remove the Short descriptions from all three commands (controller, webhook, and ca-injector)?

I think so. Agree, @maelvls?

prasad89 · 2025-09-15T06:31:36Z

Should we go ahead and remove the Short descriptions from all three commands (controller, webhook, and ca-injector)?

I think so. Agree, @maelvls?

and what about printing log version information when starting do we still need to do it for each of them, right?

maelvls · 2025-09-15T18:16:01Z

Yes, I agree too, Short can go away.

Yes, printing that log line needs to be done for each one

…or commands Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

erikgb

@prasad89, I think you need to duplicate what you have done for the controller app to the other apps.

Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

cmd/cainjector/app/cainjector.go

erikgb

/lgtm

Leaving the approve to @maelvls. 😉

maelvls · 2025-09-19T08:06:41Z

Hey, just letting you know that I'm trying to test the PR manually, it's taking me a bit of time to remember how to build the images and run them 😅

maelvls · 2025-09-19T15:23:06Z

I was able to test the changes locally:

$ make e2e-setup

$ k logs -n cert-manager deployments/cert-manager | head -1
I0919 15:14:22.507912       1 controller.go:74] "starting cert-manager controller" logger="cert-manager.controller" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

$ k logs -n cert-manager deployments/cert-manager-cainjector | head -1
I0919 15:14:22.492525       1 cainjector.go:46] "starting cert-manager ca-injector" logger="cert-manager.cainjector" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

$ k logs -n cert-manager deployments/cert-manager-webhook | head -1
I0919 15:14:22.516405       1 webhook.go:47] "starting cert-manager webhook" logger="cert-manager.webhook.webhook" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

All good, excellent work!

/lgtm
/approve

cert-manager-prow · 2025-09-19T15:23:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maelvls

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [maelvls]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

prasad89 · 2025-09-19T15:24:43Z

I was able to test the changes locally:

$ make e2e-setup

$ k logs -n cert-manager deployments/cert-manager | head -1
I0919 15:14:22.507912       1 controller.go:74] "starting cert-manager controller" logger="cert-manager.controller" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

$ k logs -n cert-manager deployments/cert-manager-cainjector | head -1
I0919 15:14:22.492525       1 cainjector.go:46] "starting cert-manager ca-injector" logger="cert-manager.cainjector" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

$ k logs -n cert-manager deployments/cert-manager-webhook | head -1
I0919 15:14:22.516405       1 webhook.go:47] "starting cert-manager webhook" logger="cert-manager.webhook.webhook" version="v1.18.0-beta.0-304-g50e387d61f6126" git_commit="50e387d61f6126c7a88f20da7f0821a84c04a90e" go_version="go1.25.1" platform="linux/arm64"

All good, excellent work!

/lgtm /approve

thanks @maelvls :)

This PR contains the following updates: | Package | Update | Change | |---|---|---| | [cert-manager](https://cert-manager.io) ([source](https://github.com/cert-manager/cert-manager)) | minor | `v1.18.2` -> `v1.19.0` | --- ### Release Notes <details> <summary>cert-manager/cert-manager (cert-manager)</summary> ### [`v1.19.0`](https://github.com/cert-manager/cert-manager/releases/tag/v1.19.0) [Compare Source](cert-manager/cert-manager@v1.18.2...v1.19.0) cert-manager is the easiest way to automatically manage certificates in Kubernetes and OpenShift clusters. This release focuses on expanding platform compatibility, improving deployment flexibility, enhancing observability, and addressing key reliability issues. > 📖 Read the full release notes at cert-manager.io: <https://cert-manager.io/docs/releases/release-notes/release-notes-1.19> Changes since `v1.18.0`: #### Feature - Add IPv6 rules to the default network policy ([#7726](cert-manager/cert-manager#7726), [@jcpunk](https://github.com/jcpunk)) - Add `global.nodeSelector` to helm chart to allow for a single `nodeSelector` to be set across all services. ([#7818](cert-manager/cert-manager#7818), [@StingRayZA](https://github.com/StingRayZA)) - Add a feature gate to default to Ingress `pathType` `Exact` in ACME HTTP01 Ingress challenge solvers. ([#7795](cert-manager/cert-manager#7795), [@sspreitzer](https://github.com/sspreitzer)) - Add generated `applyconfigurations` allowing clients to make type-safe server-side apply requests for cert-manager resources. ([#7866](cert-manager/cert-manager#7866), [@erikgb](https://github.com/erikgb)) - Added API defaults to issuer references group (cert-manager.io) and kind (Issuer). ([#7414](cert-manager/cert-manager#7414), [@erikgb](https://github.com/erikgb)) - Added `certmanager_certificate_challenge_status` Prometheus metric. ([#7736](cert-manager/cert-manager#7736), [@hjoshi123](https://github.com/hjoshi123)) - Added `protocol` field for `rfc2136` DNS01 provider ([#7881](cert-manager/cert-manager#7881), [@hjoshi123](https://github.com/hjoshi123)) - Added experimental field `hostUsers` flag to all pods. Not set by default. ([#7973](cert-manager/cert-manager#7973), [@hjoshi123](https://github.com/hjoshi123)) - Support configurable resource requests and limits for ACME HTTP01 solver pods through ClusterIssuer and Issuer specifications, allowing granular resource management that overrides global `--acme-http01-solver-resource-*` settings. ([#7972](cert-manager/cert-manager#7972), [@lunarwhite](https://github.com/lunarwhite)) - The `CAInjectorMerging` feature has been promoted to BETA and is now enabled by default ([#8017](cert-manager/cert-manager#8017), [@ThatsMrTalbot](https://github.com/ThatsMrTalbot)) - The controller, webhook and ca-injector now log their version and git commit on startup for easier debugging and support. ([#8072](cert-manager/cert-manager#8072), [@prasad89](https://github.com/prasad89)) - Updated `certificate` metrics to the collector approach. ([#7856](cert-manager/cert-manager#7856), [@hjoshi123](https://github.com/hjoshi123)) #### Bug or Regression - ACME: Increased challenge authorization timeout to 2 minutes to fix `error waiting for authorization` ([#7796](cert-manager/cert-manager#7796), [@hjoshi123](https://github.com/hjoshi123)) - BUGFIX: permitted URI domains were incorrectly used to set the excluded URI domains in the CSR's name constraints ([#7816](cert-manager/cert-manager#7816), [@kinolaev](https://github.com/kinolaev)) - Enforced ACME HTTP-01 solver validation to properly reject configurations when multiple ingress options (`class`, `ingressClassName`, `name`) are specified simultaneously ([#8021](cert-manager/cert-manager#8021), [@lunarwhite](https://github.com/lunarwhite)) - Increase maximum sizes of PEM certificates and chains which can be parsed in cert-manager, to handle leaf certificates with large numbers of DNS names or other identities ([#7961](cert-manager/cert-manager#7961), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Reverted adding the `global.rbac.disableHTTPChallengesRole` Helm option. ([#7836](cert-manager/cert-manager#7836), [@inteon](https://github.com/inteon)) - This change removes the `path` label of core ACME client metrics and will require users to update their monitoring dashboards and alerting rules if using those metrics. ([#8109](cert-manager/cert-manager#8109), [@mladen-rusev-cyberark](https://github.com/mladen-rusev-cyberark)) - Use the latest version of `ingress-nginx` in E2E tests to ensure compatibility ([#7792](cert-manager/cert-manager#7792), [@wallrj](https://github.com/wallrj)) #### Other (Cleanup or Flake) - Helm: Fix naming template of `tokenrequest` RoleBinding resource to improve consistency ([#7761](cert-manager/cert-manager#7761), [@lunarwhite](https://github.com/lunarwhite)) - Improve error messages when certificates, CRLs or private keys fail admission due to malformed or missing PEM data ([#7928](cert-manager/cert-manager#7928), [@SgtCoDFish](https://github.com/SgtCoDFish)) - Major upgrade of Akamai SDK. NOTE: The new version has not been fully tested end-to-end due to the lack of cloud infrastructure. ([#8003](cert-manager/cert-manager#8003), [@hjoshi123](https://github.com/hjoshi123)) - Update kind images to include the Kubernetes 1.33 node image ([#7786](cert-manager/cert-manager#7786), [@wallrj](https://github.com/wallrj)) - Use `maps.Copy` for cleaner map handling ([#8092](cert-manager/cert-manager#8092), [@quantpoet](https://github.com/quantpoet)) - Vault: Migrate Vault E2E add-on tests from deprecated `vault-client-go` to the new `vault/api` client. ([#8059](cert-manager/cert-manager#8059), [@armagankaratosun](https://github.com/armagankaratosun)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Reviewed-on: https://gitea.alexlebens.dev/alexlebens/infrastructure/pulls/1711 Co-authored-by: Renovate Bot <renovate-bot@alexlebens.net> Co-committed-by: Renovate Bot <renovate-bot@alexlebens.net>

wallrj-cyberark · 2025-10-15T15:58:28Z

@prasad89 We have released this. Please test and feedback: https://github.com/cert-manager/cert-manager/releases/tag/v1.19.1

cert-manager-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2025

feat: log version information when starting the cert-manager controller

7b76d8e

Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

prasad89 force-pushed the issue#8067 branch from 0588f83 to 7b76d8e Compare September 13, 2025 10:23

cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 13, 2025

erikgb requested a review from Copilot September 13, 2025 14:32

Copilot AI reviewed Sep 13, 2025

View reviewed changes

cert-manager-prow bot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 13, 2025

erikgb reviewed Sep 13, 2025

View reviewed changes

erikgb requested a review from maelvls September 13, 2025 14:44

remove the Short descriptions from controller, webhook, and ca-inject…

cb3181b

…or commands Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

cert-manager-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 16, 2025

erikgb reviewed Sep 16, 2025

View reviewed changes

print log version information when starting webhook and ca-injector

50e387d

Signed-off-by: prasad89 <vdbhaleraovb@gmail.com>

prasad89 requested a review from erikgb September 16, 2025 06:03

erikgb reviewed Sep 16, 2025

View reviewed changes

cmd/cainjector/app/cainjector.go Show resolved Hide resolved

prasad89 changed the title ~~feat: log version information when starting the cert-manager controller~~ feat: log version information when starting the cert-manager controller, webhook and ca-injector Sep 16, 2025

erikgb reviewed Sep 16, 2025

View reviewed changes

cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025

maelvls added the cybr Used by CyberArk-employed maintainers to report to line management what's being worked on. label Sep 16, 2025

cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2025

cert-manager-prow bot merged commit e2aa55c into cert-manager:master Sep 19, 2025
6 checks passed

Conversation

prasad89 commented Sep 13, 2025 • edited by maelvls Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Motivation

Kind

Release Note

Uh oh!

cert-manager-prow bot commented Sep 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

erikgb commented Sep 13, 2025

Uh oh!

erikgb left a comment

Choose a reason for hiding this comment

Uh oh!

prasad89 commented Sep 15, 2025

Uh oh!

erikgb commented Sep 15, 2025

Uh oh!

prasad89 commented Sep 15, 2025

Uh oh!

maelvls commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikgb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erikgb left a comment

Choose a reason for hiding this comment

Uh oh!

maelvls commented Sep 19, 2025

Uh oh!

maelvls commented Sep 19, 2025

Uh oh!

cert-manager-prow bot commented Sep 19, 2025

Uh oh!

prasad89 commented Sep 19, 2025

Uh oh!

Uh oh!

wallrj-cyberark commented Oct 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

prasad89 commented Sep 13, 2025 •

edited by maelvls

Loading

maelvls commented Sep 15, 2025 •

edited

Loading