Skip to content

Fix typo in Certificate.Spec.SignatureAlgorithm documentation#7789

Merged
cert-manager-prow[bot] merged 2 commits into
cert-manager:masterfrom
wallrj:signature-algorithm-typo
Jun 10, 2025
Merged

Fix typo in Certificate.Spec.SignatureAlgorithm documentation#7789
cert-manager-prow[bot] merged 2 commits into
cert-manager:masterfrom
wallrj:signature-algorithm-typo

Conversation

@wallrj

@wallrj wallrj commented Jun 10, 2025

Copy link
Copy Markdown
Member

@wallrj-cyberark
Fix typo in Certificate API documentation
d41df23 
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark
make generate
9d5b140 
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@cert-manager-prow cert-manager-prow Bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/api Indicates a PR directly modifies the 'pkg/apis' directory needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/deploy Indicates a PR modifies deployment configuration labels Jun 10, 2025
@wallrj wallrj mentioned this pull request Jun 10, 2025
Merged
@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@wallrj wallrj mentioned this pull request Jun 10, 2025
Merged
@wallrj

wallrj commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

/cherry-pick release-1.18

@cert-manager-bot

cert-manager-bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

@wallrj: once the present PR merges, I will cherry-pick it on top of release-1.18 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@inteon

inteon commented Jun 10, 2025

Copy link
Copy Markdown
Member

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2025
@cert-manager-prow

cert-manager-prow Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025
@inteon

inteon commented Jun 10, 2025

Copy link
Copy Markdown
Member

/kind cleanup

@cert-manager-prow cert-manager-prow Bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 10, 2025
@cert-manager-prow cert-manager-prow Bot merged commit 2039db6 into cert-manager:master Jun 10, 2025
6 checks passed
@cert-manager-bot

cert-manager-bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

@wallrj: new pull request created: #7790

Details

In response to this:

/cherry-pick release-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-bot cert-manager-bot mentioned this pull request Jun 10, 2025
Merged
@wallrj wallrj deleted the signature-algorithm-typo branch June 10, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Indicates a PR directly modifies the 'pkg/apis' directory area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wallrj @cert-manager-bot @inteon @wallrj-cyberark