Upgrade dependencies#7094
Conversation
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
|
/test ? |
|
@inteon: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cert-manager-master-e2e-v1-30-bestpractice-install |
Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
|
/approve |
|
Hey, please explain why this PR is worth it. I don't see the point of upgrading to the latest versions of every lib unless we are about to do a release. If there is a reason, such as upgrading as early as possible to the latest controller-runtime version so that we don't get stuck when trying to upgrade to the latest versions of the If you want this practice of upgrading controller-runtime often and you would prefer not to have to write that down in each PR description, we can add that policy to https://cert-manager.io/docs/contributing/. You can use @erikgb's #6967 as an example of description. Also, what's the process for upgrading all the |
I added replies to your questions in the PR description. |
|
/test pull-cert-manager-master-e2e-v1-30-bestpractice-install |
|
Thanks for the clarification! /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon, maelvls The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| $(bin_dir)/downloaded/pebble-$(PEBBLE_COMMIT).tar.gz: | $(bin_dir)/downloaded | ||
| $(CURL) https://github.com/letsencrypt/pebble/archive/$(PEBBLE_COMMIT).tar.gz -o $@ | ||
| $(CURL) https://github.com/inteon/pebble/archive/$(PEBBLE_COMMIT).tar.gz -o $@ |
There was a problem hiding this comment.
I was not able to upgrade pebble to the latest version, because of this: letsencrypt/pebble#468
So, I fixed the issue in my branch with the goal of upstreaming this change, but the PR was denied.
There was a problem hiding this comment.
So, I guess we should downgrade again or fix this in another manner.
| IMAGE_projectcontour_arm64 := ghcr.io/projectcontour/contour:v1.29.1@sha256:dbfec77951e123bf383a09412a51df218b716aaf3fe7b2778bb2f208ac495dc5 | ||
|
|
||
| # https://github.com/letsencrypt/pebble/releases | ||
| PEBBLE_COMMIT = ba5f81dd80fa870cbc19326f2d5a46f45f0b5ee3 |
There was a problem hiding this comment.
But this commit doesn't contain your Ed25519 changes
it should be this, right?
By continuously upgrading our dependencies, we reduce the amount of breaking changes that we have to fix when upgrading right before a release. Instead, by keeping dependencies up-to-date, we fix breaking changes as they come.
Go dependencies were upgraded by running
go-mod-upgradeat the root (with the go workspace setup) and callingmake tidyafterwards.Kind
/kind cleanup
Release Note