Skip to content

Upgrade K8s dependencies to v0.30.0#6967

Merged
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:upgrade-k8s
Apr 28, 2024
Merged

Upgrade K8s dependencies to v0.30.0#6967
cert-manager-prow[bot] merged 1 commit intocert-manager:masterfrom
erikgb:upgrade-k8s

Conversation

@erikgb
Copy link
Copy Markdown
Member

@erikgb erikgb commented Apr 27, 2024 •
edited
Loading

Pull Request Motivation

Upgrading controller-runtime to the latest release (v0.18.0) to keep up with upstream Kubernetes dependencies (v0.30.x). I have also ensured all direct K8s dependencies in all modules are now v0.30.0.

Note: K8s modules no longer depend on Ginkgo, which means we can eliminate this dependency in cert-manager also. Thanks to assistance from @inteon fixing Makefile issues in this PR after ginkgo disappeared from go.mod.

Kind

/kind cleanup

Release Note

NONE

@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Apr 27, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cert-manager-prow cert-manager-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 27, 2024
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-verify

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test all

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-test

@erikgb erikgb mentioned this pull request Apr 27, 2024
Merged
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-e2e-v1-28

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test all

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-verify

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-verify

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-verify

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 27, 2024

/test pull-cert-manager-master-make-verify

@inteon inteon self-assigned this Apr 28, 2024
@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 28, 2024

/test all

@erikgb
Copy link
Copy Markdown
Member Author

erikgb commented Apr 28, 2024

/kind cleanup

@cert-manager-prow cert-manager-prow bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 28, 2024
@erikgb erikgb changed the title WIP: Upgrade controller-runtime to v0.18.0 WIP: Upgrade K8s dependencies to v0.30.0 Apr 28, 2024
@erikgb erikgb changed the title WIP: Upgrade K8s dependencies to v0.30.0 Upgrade K8s dependencies to v0.30.0 Apr 28, 2024
@erikgb erikgb marked this pull request as ready for review April 28, 2024 10:39
@cert-manager-prow cert-manager-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2024
@erikgb
Upgrade K8s dependencies to v0.30.0
8f99f40 
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
inteon
inteon reviewed Apr 28, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@inteon inteon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!
/approve
/lgtm

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2024
@cert-manager-prow
Copy link
Copy Markdown
Contributor

cert-manager-prow bot commented Apr 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2024
@cert-manager-prow cert-manager-prow bot merged commit 02c8938 into cert-manager:master Apr 28, 2024
@maelvls maelvls mentioned this pull request Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@inteon inteon inteon left review comments

Assignees

@inteon inteon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme Indicates a PR directly modifies the ACME Issuer code area/deploy Indicates a PR modifies deployment configuration area/testing Issues relating to testing dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@erikgb @inteon