Skip to content

Fix mistakenly changed cainjector image value#6692

Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:fixcainjector
Jan 31, 2024
Merged

Fix mistakenly changed cainjector image value#6692
jetstack-bot merged 1 commit intocert-manager:masterfrom
SgtCoDFish:fixcainjector

Conversation

@SgtCoDFish
Copy link
Copy Markdown
Member

@SgtCoDFish SgtCoDFish commented Jan 31, 2024 •
edited by wallrj
Loading

Introduced in #6639

This was discovered during the release of cert-manager v1.14.0. See the summary on Slack

Fixes: #6646

Kind

/kind bug

Release Note

Fix broken cainjector image value in Helm chart

@SgtCoDFish
Fix mistakenly changed cainjector image value
a9ba9d8 
See cert-manager#6639

This was discovered during the release of cert-manager v1.14.0. See the
summary on Slack:

https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1706723744656039?thread_ts=1706713005.073879&cid=CDEQJ0Q8M

Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jan 31, 2024
@SgtCoDFish
Copy link
Copy Markdown
Member Author

SgtCoDFish commented Jan 31, 2024

/cherry-pick release-1.14

@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.14 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/deploy Indicates a PR modifies deployment configuration labels Jan 31, 2024
@wallrj wallrj linked an issue Jan 31, 2024 that may be closed by this pull request
cainjector leader election fails due to lease issues #6646
Closed
wallrj
wallrj approved these changes Jan 31, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@jetstack-bot jetstack-bot merged commit ce3d057 into cert-manager:master Jan 31, 2024
@jetstack-bot jetstack-bot mentioned this pull request Jan 31, 2024
Merged
@jetstack-bot
Copy link
Copy Markdown
Contributor

jetstack-bot commented Jan 31, 2024

@SgtCoDFish: new pull request created: #6693

Details

In response to this:

/cherry-pick release-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wallrj wallrj mentioned this pull request Feb 1, 2024
Closed
73 tasks
@SgtCoDFish SgtCoDFish deleted the fixcainjector branch February 1, 2024 09:43
@wallrj wallrj added this to the 1.14 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wallrj wallrj wallrj approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/deploy Indicates a PR modifies deployment configuration dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

1.14

Development

Successfully merging this pull request may close these issues.

cainjector leader election fails due to lease issues

3 participants

@SgtCoDFish @jetstack-bot @wallrj