Auto generate Helm docs#6639
Merged
jetstack-bot merged 4 commits intocert-manager:masterfrom Jan 16, 2024
Merged
Conversation
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
9403914 to
af4685c
Compare
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
e81fbc5 to
e8987bc
Compare
inteon
reviewed
Jan 15, 2024
Signed-off-by: Adam Talbot <adam.talbot@venafi.com>
Member
|
LGTM |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
SgtCoDFish
added a commit
to SgtCoDFish/cert-manager
that referenced
this pull request
Jan 31, 2024
See cert-manager#6639 This was discovered during the release of cert-manager v1.14.0. See the summary on Slack: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1706723744656039?thread_ts=1706713005.073879&cid=CDEQJ0Q8M Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
jetstack-bot
pushed a commit
to jetstack-bot/cert-manager
that referenced
this pull request
Jan 31, 2024
See cert-manager#6639 This was discovered during the release of cert-manager v1.14.0. See the summary on Slack: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1706723744656039?thread_ts=1706713005.073879&cid=CDEQJ0Q8M Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
logand22
pushed a commit
to gravitational/cert-manager
that referenced
this pull request
Mar 8, 2024
See cert-manager#6639 This was discovered during the release of cert-manager v1.14.0. See the summary on Slack: https://kubernetes.slack.com/archives/CDEQJ0Q8M/p1706723744656039?thread_ts=1706713005.073879&cid=CDEQJ0Q8M Signed-off-by: Ashley Davis <ashley.davis@venafi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
In order to avoid missing docs we can autogenerate the README from the values.yaml, this PR adds comments to all values in the values.yaml file and adds automation to update the chart README in place
Updated README can be previewed here:
https://github.com/ThatsMrTalbot/cert-manager/blob/feat/auto-generate-helm-docs/deploy/charts/cert-manager/README.template.md
Kind
Release Note