Merged
Conversation
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
- runs "make update-codegen" - adds codegen verification to make tests - changes hack/(update|verify)-codegen.sh to just call make - removes bazel codegen test so it's not automatically run in CI Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
- includes a run of make update-crds which causes some trivial changes - updates version of YQ to latest - makes hack/update-crds.sh just call make - makes hack/verify-crds.sh just call make - moves functionality of hack/verify-crds.sh to hack/check-crds.sh, using the makefile for generating alternative CRDs for comparison - removes the bazel test associated with CRDs Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
There's no need to run these twice in our presubmit tests Signed-off-by: Ashley Davis <ashley.davis@jetstack.io>
SgtCoDFish
commented
Jun 27, 2022
| type: array | ||
| items: | ||
| description: 'KeyUsage specifies valid usage contexts for keys. See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3 https://tools.ietf.org/html/rfc5280#section-4.2.1.12 Valid KeyUsage values are as follows: "signing", "digital signature", "content commitment", "key encipherment", "key agreement", "data encipherment", "cert sign", "crl sign", "encipher only", "decipher only", "any", "server auth", "client auth", "code signing", "email protection", "s/mime", "ipsec end system", "ipsec tunnel", "ipsec user", "timestamping", "ocsp signing", "microsoft sgc", "netscape sgc"' | ||
| description: 'KeyUsage specifies valid usage contexts for keys. See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3 https://tools.ietf.org/html/rfc5280#section-4.2.1.12 Valid KeyUsage values are as follows: "signing", "digital signature", "content commitment", "key encipherment", "key agreement", "data encipherment", "cert sign", "crl sign", "encipher only", "decipher only", "any", "server auth", "client auth", "code signing", "email protection", "s/mime", "ipsec end system", "ipsec tunnel", "ipsec user", "timestamping", "ocsp signing", "microsoft sgc", "netscape sgc"' |
Member
Author
There was a problem hiding this comment.
note: this was the result of running the latest versions of the tools; it's a whitespace change!
SgtCoDFish
commented
Jun 27, 2022
Comment on lines
-19
to
-35
| py_test( | ||
| name = "verify-boilerplate", | ||
| srcs = ["verify_boilerplate.py"], | ||
| data = ["@//:all-srcs"], | ||
| main = "verify_boilerplate.py", | ||
| python_version = "PY3", | ||
| tags = ["lint"], | ||
| ) | ||
|
|
||
| sh_test( | ||
| name = "verify-errexit", | ||
| srcs = ["verify-errexit.sh"], | ||
| data = [ | ||
| "@//:all-srcs", | ||
| ], | ||
| tags = ["lint"], | ||
| ) |
Member
Author
There was a problem hiding this comment.
note: these were added to make a long time ago!
SgtCoDFish
commented
Jun 27, 2022
Comment on lines
-210
to
-231
| sh_binary( | ||
| name = "update-gofmt", | ||
| srcs = ["update-gofmt.sh"], | ||
| args = [ | ||
| "$(location %s)" % GOFMT, | ||
| ], | ||
| data = [ | ||
| GOFMT, | ||
| ], | ||
| ) | ||
|
|
||
| sh_test( | ||
| name = "verify-gofmt", | ||
| srcs = ["verify-gofmt.sh"], | ||
| args = [ | ||
| "$(location %s)" % GOFMT, | ||
| ], | ||
| data = [ | ||
| GOFMT, | ||
| "@//:all-srcs", | ||
| ], | ||
| ) |
Member
Author
There was a problem hiding this comment.
note: this is replaced by a verify-goimports make target
SgtCoDFish
commented
Jun 27, 2022
Comment on lines
+72
to
+75
| if configShallowCopy.UserAgent == "" { | ||
| configShallowCopy.UserAgent = rest.DefaultKubernetesUserAgent() | ||
| } | ||
|
|
Member
Author
There was a problem hiding this comment.
note: again, this is the result of running the codegen with the same commands using the latest versions of the tools
jakexks
approved these changes
Jun 27, 2022
Member
jakexks
left a comment
There was a problem hiding this comment.
I think this looks good. Thanks for leaving the old script names there, even if they now just call the make targets.
/lgtm
| description: Usages is the set of x509 usages that are requested for the certificate. If usages are set they SHOULD be encoded inside the CSR spec Defaults to `digital signature` and `key encipherment` if not specified. | ||
| type: array | ||
| items: | ||
| description: 'KeyUsage specifies valid usage contexts for keys. See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3 https://tools.ietf.org/html/rfc5280#section-4.2.1.12 Valid KeyUsage values are as follows: "signing", "digital signature", "content commitment", "key encipherment", "key agreement", "data encipherment", "cert sign", "crl sign", "encipher only", "decipher only", "any", "server auth", "client auth", "code signing", "email protection", "s/mime", "ipsec end system", "ipsec tunnel", "ipsec user", "timestamping", "ocsp signing", "microsoft sgc", "netscape sgc"' |
Member
There was a problem hiding this comment.
I'm assuming this is also from re-running the generators with the latest updates?
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jakexks, SgtCoDFish The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Motivation
This is a follow-up to #5111, focusing entirely on CRDs and codegen. Also removes any bazel test in
hackwhich has a make equivalent.Kind
/kind cleanup
Release Note