Skip to content

[release-1.5] Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0#4385

Merged
jetstack-bot merged 1 commit into
cert-manager:release-1.5from
jetstack-bot:cherry-pick-4373-to-release-1.5
Aug 18, 2021
Merged

[release-1.5] Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0#4385
jetstack-bot merged 1 commit into
cert-manager:release-1.5from
jetstack-bot:cherry-pick-4373-to-release-1.5

Conversation

@jetstack-bot

@jetstack-bot jetstack-bot commented Aug 18, 2021 •
edited by maelvls
Loading

Copy link
Copy Markdown
Contributor

This is an automated cherry-pick of #4373

/assign SgtCoDFish

Fix a regression introduced in v1.5.0 where the Ingress created for solving HTTP-01 challenges was created with
`pathType: Exact` instead of `pathType: ImplementationSpecific`.

@jakexks
Fix regression in Ingress PathType introduced in v1.5.0
9037c7c 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jetstack-bot jetstack-bot mentioned this pull request Aug 18, 2021
Merged
@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 18, 2021
@jetstack-bot jetstack-bot added this to the v1.5 milestone Aug 18, 2021
@jetstack-bot jetstack-bot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2021
@SgtCoDFish SgtCoDFish added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Aug 18, 2021
@SgtCoDFish

SgtCoDFish commented Aug 18, 2021

Copy link
Copy Markdown
Member

/lgtm
/approve
/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 18, 2021
@jetstack-bot

jetstack-bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jetstack-bot, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2021
@jakexks

jakexks commented Aug 18, 2021

Copy link
Copy Markdown
Member

/retest

1 similar comment
@jakexks

jakexks commented Aug 18, 2021

Copy link
Copy Markdown
Member

/retest

@jetstack-bot jetstack-bot merged commit bd55aa0 into cert-manager:release-1.5 Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SgtCoDFish SgtCoDFish

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

3 participants

@jetstack-bot @SgtCoDFish @jakexks