Skip to content

Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0#4373

Merged
jetstack-bot merged 1 commit into
cert-manager:masterfrom
jakexks:ingress_path_type
Aug 18, 2021
Merged

Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0#4373
jetstack-bot merged 1 commit into
cert-manager:masterfrom
jakexks:ingress_path_type

Conversation

@jakexks

@jakexks jakexks commented Aug 17, 2021 •
edited by maelvls
Loading

Copy link
Copy Markdown
Member

What this PR does / why we need it:

While upgrading from v1beta1 Ingress to v1 Ingress, the PathType was hardcoded to exact, which broke compatibility with Ingress-GCE.

This changes the PathType to ImplementationSpecific, which is the same behaviour as omitting it in a v1beta1 Ingress.

Which issue this PR fixes: fixes #4371

Special notes for your reviewer:

For what it's worth, this means ingress-gce is not a valid Ingress controller, as controllers must support all 3 valid path types.

Release note:

Fix a regression introduced in v1.5.0 where the Ingress created for solving HTTP-01 challenges was created with
`pathType: Exact` instead of `pathType: ImplementationSpecific`.

@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 17, 2021
@jakexks

jakexks commented Aug 17, 2021

Copy link
Copy Markdown
Member Author

/kind bug

@jetstack-bot jetstack-bot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 17, 2021
@jakexks jakexks changed the title Fix regression in Ingress PathType introduced in v1.5.0 Fix regression in ACME HTTP-01 Ingress Solver introduced in v1.5.0 Aug 17, 2021
@SgtCoDFish

SgtCoDFish commented Aug 17, 2021

Copy link
Copy Markdown
Member

/cherry-pick release-1.5

@jetstack-bot

jetstack-bot commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

@SgtCoDFish: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

SgtCoDFish
SgtCoDFish approved these changes Aug 17, 2021
View reviewed changes

@SgtCoDFish SgtCoDFish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2021
@jetstack-bot

jetstack-bot commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jakexks, SgtCoDFish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@SgtCoDFish

SgtCoDFish commented Aug 18, 2021

Copy link
Copy Markdown
Member

/test pull-cert-manager-e2e-v1-22

@jakexks
Fix regression in Ingress PathType introduced in v1.5.0
38ce03e 
Signed-off-by: Jake Sanders <i@am.so-aweso.me>
@jakexks jakexks force-pushed the ingress_path_type branch from bdf6298 to 38ce03e Compare August 18, 2021 14:16
@jetstack-bot jetstack-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@JoshVanL

JoshVanL commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2021
@jetstack-bot jetstack-bot merged commit 18a15fe into cert-manager:master Aug 18, 2021
@jetstack-bot jetstack-bot mentioned this pull request Aug 18, 2021
Merged
@jetstack-bot

jetstack-bot commented Aug 18, 2021

Copy link
Copy Markdown
Contributor

@SgtCoDFish: new pull request created: #4385

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jakexks jakexks deleted the ingress_path_type branch August 18, 2021 15:22
@jetstack-bot jetstack-bot mentioned this pull request Aug 20, 2021
Closed
@sspreitzer sspreitzer mentioned this pull request May 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SgtCoDFish SgtCoDFish SgtCoDFish approved these changes

Assignees

@SgtCoDFish SgtCoDFish

@JoshVanL JoshVanL

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ingress routes for challenges created with pathType: Exact

4 participants

@jakexks @SgtCoDFish @jetstack-bot @JoshVanL