Skip to content

align with upstream#642

Merged
galsalomon66 merged 1 commit intoceph:ceph-squidfrom
galsalomon66:add_event_stream_error_exception_handling
Apr 19, 2025
Merged

align with upstream#642
galsalomon66 merged 1 commit intoceph:ceph-squidfrom
galsalomon66:add_event_stream_error_exception_handling

Conversation

@galsalomon66
Copy link
Copy Markdown
Contributor

@galsalomon66 galsalomon66 commented Apr 18, 2025

revert the revert
#630

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
@galsalomon66 galsalomon66 merged commit 8910664 into ceph:ceph-squid Apr 19, 2025
Comment on lines -1361 to +1371
#find_processing_error = res_multiple_defintion.find("s3select-ProcessingTime-Error")
assert ((res_multiple_defintion.find("s3select-ProcessingTime-Error")) >= 0)
#find_processing_error = res_multiple_defintion.find("ProcessingTimeError")
assert ((res_multiple_defintion.find("ProcessingTimeError")) >= 0)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is failing again on squid

        #find_processing_error = res_multiple_defintion.find("ProcessingTimeError")
>       assert ((res_multiple_defintion.find("ProcessingTimeError")) >= 0)
E       AssertionError: assert -1 >= 0
E        +  where -1 = <built-in method find of str object at 0x7fc86b5b02a0>('ProcessingTimeError')
E        +    where <built-in method find of str object at 0x7fc86b5b02a0> = 'An error occurred (s3select-ProcessingTime-Error) when calling the SelectObjectContent operation: [int failed : alias {c11} or column not exist in schema]'.find

https://pulpito.ceph.com/yuriw-2025-04-21_17:45:35-rgw-wip-yuri4-testing-2025-04-21-0740-squid-distro-default-smithi/
https://qa-proxy.ceph.com/teuthology/yuriw-2025-04-21_17:45:35-rgw-wip-yuri4-testing-2025-04-21-0740-squid-distro-default-smithi/8250040/teuthology.log

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@galsalomon66 i assume there's some s3select backport that's on downstream branches but not on upstream squid. it's very important that this 'ceph-squid' branch track our upstream squid release

maybe you can track down the missing backport?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably re-re-revert so this doesn't block further testing for 19.2.3

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants