squid: rgw/s3select #62959
Merged
yuriw merged 7 commits intoceph:squidfrom May 19, 2025
Merged
Conversation
update for the engine_version message s3select submodule Signed-off-by: galsalomon66 <gal.salomon@gmail.com> (cherry picked from commit 852c1d9)
in some cases the error message does not return to client, connection got broken (invalid chunk length) fix another broken connection all data-source to use same API for sending error-response add the option rgw_s3select_disable(boolean). upon turning-on this option, it rejects s3select-requests with an error-message editorial. rollback to ceph-master. the ceph/s3-tests#561 must be merged with ceph-PR Signed-off-by: Gal Salomon <gal.salomon@gmail.com> (cherry picked from commit 53ad57c)
…sues Update arrow submodule. Signed-off-by: J. Eric Ivancich <ivancich@redhat.com> (cherry picked from commit 06d0574)
Previously, these fields remained constant despite the possibility of populating them with appropriate values. Ref. https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html Fixes: https://tracker.ceph.com/issues/65468 Signed-off-by: Seena Fallah <seenafallah@gmail.com> (cherry picked from commit 3a103f2)
RGW option per parquet read-buffer. identation. alignment with s3select updated APIs. removing the JSON format part, it is not align with the current s3-tests (will be done on different part) move the parquet-reader-setup call location. editorial. the returned-bytes metric was missing upon parquet flow. Signed-off-by: Gal Salomon <gal.salomon@gmail.com> (cherry picked from commit 597a702)
…ifies them if necessary(invalid read) Signed-off-by: Gal Salomon <gal.salomon@gmail.com> (cherry picked from commit 2f81b4d)
Signed-off-by: Gal Salomon <gal.salomon@gmail.com> (cherry picked from commit 141b675)
adamemerson
approved these changes
Apr 25, 2025
Contributor
|
@galsalomon66 Thank you very much! |
Contributor
|
@yuriw Could we merge this into squid? It's the cleaned up version of the PR we re-ran with. |
This was referenced Apr 25, 2025
Closed
Contributor
|
https://jenkins.ceph.com/job/ceph-api/94604/
|
Contributor
|
jenkins test api |
adamemerson
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick's per squid:s3select
https://tracker.ceph.com/issues/71059
https://tracker.ceph.com/issues/68829
https://tracker.ceph.com/issues/65468
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job Definition