use empty string for TestObjectCreateBadMd5Empty#12
Merged
alimaredia merged 1 commit intoceph:masterfrom Jan 20, 2023
Merged
Conversation
this test case has been passing, but not in the way in we thought the use of " " here was actually causing 403 SignatureDoesNotMatch; apparently because java is signing the header value of " ", where boto and radosgw are stripping that whitespace from header values when calculating the signature on 403 errors, the java client retries this request. because of a separate bug https://tracker.ceph.com/issues/58286 in radosgw's http parser, the retried request failed with 500 Bad Request 500 errors aren't retried, so this is the error code caught by the test case this test case was copied from test_object_create_bad_md5_empty() in s3-tests, where it instead expects 400 InvalidDigest Signed-off-by: Casey Bodley <cbodley@redhat.com>
alimaredia
approved these changes
Jan 20, 2023
Author
|
the fix merged in ceph/ceph#49642, so i've cherry-picked this to ceph-master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this test case has been passing, but not in the way in we thought
the use of " " here was actually causing 403 SignatureDoesNotMatch; apparently because java is signing the header value of " ", where boto and radosgw are stripping that whitespace from header values when calculating the signature
on 403 errors, the java client retries this request. because of a separate bug https://tracker.ceph.com/issues/58286 in radosgw's http parser, the retried request failed with 500 Bad Request
500 errors aren't retried, so this is the error code caught by the test case
this test case was copied from test_object_create_bad_md5_empty() in s3-tests, where it instead expects 400 InvalidDigest