Skip to content

docs: add badges to README#1221

Merged
mergify[bot] merged 1 commit into
ceph:masterfrom
obnoxxx:patch-1
Jan 13, 2026
Merged

docs: add badges to README#1221
mergify[bot] merged 1 commit into
ceph:masterfrom
obnoxxx:patch-1

Conversation

@obnoxxx

@obnoxxx obnoxxx commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Add badges for CI status and go-report to the README.

Checklist

  • Added tests for features and functional changes
  • Public functions and types are documented
  • Standard formatting is applied to Go code
  • Is this a new API? Added a new file that begins with //go:build ceph_preview
  • Ran make api-update to record new APIs

phlogistonjohn
phlogistonjohn approved these changes Jan 13, 2026
View reviewed changes

@phlogistonjohn phlogistonjohn left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@anoopcs9 do you think we should add these badges? (I'm leaving off the label to take your feedback but still approve)

anoopcs9
anoopcs9 approved these changes Jan 13, 2026
View reviewed changes

@anoopcs9 anoopcs9 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK to me.

@anoopcs9 do you think we should add these badges? (I'm leaving off the label to take your feedback but still approve)

I was skeptical about goreportcard.com but it seems like a widely accepted code quality assessment online service and we have an A+ (most likely a score between 90-100). Let’s use it !

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label Jan 13, 2026
@anoopcs9

anoopcs9 commented Jan 13, 2026

Copy link
Copy Markdown
Collaborator

@Mergifyio rebase

@obnoxxx @anoopcs9
README: add badges
65dd83d 
Add  badges for CI status and go-report to the README.


Signed-off-by: Michael Adam <obnox@samba.org>
@mergify

mergify Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@mergify mergify Bot added the queued label Jan 13, 2026
@mergify

mergify Bot commented Jan 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Merge Queue Status

🚫 The pull request has left the queue (rule: default) at 97ea82d

This pull request spent 49 seconds in the queue, with no time running CI.

Reason

The pull request #1221 has been manually updated

Hint

If you want to requeue this pull request, you can post a @mergifyio requeue comment.

@mergify mergify Bot added queued and removed queued labels Jan 13, 2026
@mergify mergify Bot merged commit 18f6f20 into ceph:master Jan 13, 2026
17 checks passed
@mergify

mergify Bot commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

✅ The pull request has been merged at 65dd83d

This pull request spent 7 seconds in the queue, with no time running CI.
The checks were run in-place.

Required conditions to merge
  • #approved-reviews-by >= 1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
  • any of [🛡 GitHub branch protection]:
    • check-success = check
    • check-neutral = check
    • check-skipped = check
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (pacific)
    • check-neutral = test-suite (pacific)
    • check-skipped = test-suite (pacific)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (quincy)
    • check-neutral = test-suite (quincy)
    • check-skipped = test-suite (quincy)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (reef)
    • check-neutral = test-suite (reef)
    • check-skipped = test-suite (reef)
  • any of [🛡 GitHub branch protection]:
    • check-success = test-suite (squid)
    • check-neutral = test-suite (squid)
    • check-skipped = test-suite (squid)

@mergify mergify Bot removed the queued label Jan 13, 2026
@obnoxxx obnoxxx deleted the patch-1 branch January 14, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anoopcs9 anoopcs9 anoopcs9 approved these changes

@phlogistonjohn phlogistonjohn phlogistonjohn approved these changes

Assignees

No one assigned

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@obnoxxx @anoopcs9 @phlogistonjohn