Skip to content

Conversation

@anoopcs9
Copy link
Collaborator

@anoopcs9 anoopcs9 commented May 8, 2025

With the third party github actions disabled we directly make use of gh command line to create a bare minimum GitHub issue for any API updates to be performed in the next upcoming release.

@anoopcs9 anoopcs9 added the no-API This PR does not include any changes to the public API of a go-ceph package label May 8, 2025
@anoopcs9 anoopcs9 changed the title workflows: Use gh command line to create issues workflows: Use gh command line to create issues May 8, 2025
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented May 8, 2025

Here's the change in action: anoopcs9#1

@anoopcs9 anoopcs9 requested a review from phlogistonjohn May 8, 2025 07:15
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented May 8, 2025

Should we add the additional complexity to check for any existing issues with the same title?

@phlogistonjohn
Copy link
Collaborator

Should we add the additional complexity to check for any existing issues with the same title?

No, I think it would be unnecessary given how infrequently we run the action. If it starts to be annoying in the future we can revisit that then.
If you do want to earn bonus points it might make sense to adjust the script that generates the markdown file to do it in a gh friendly way and avoid the extra sed commands.

@anoopcs9 anoopcs9 force-pushed the gh-cmd-issue-create branch from af559ab to 855db3e Compare May 9, 2025 10:39
@anoopcs9
Copy link
Collaborator Author

anoopcs9 commented May 9, 2025

It took me sometime to realize the complexity with handling multiline strings while storing information in GitHub actions which I finally avoided by writing the necessary contents to a file as indicated in the docs. See anoopcs9#4 for a sample issue created with the current changes.

An alternative is to retain the current logic in script to create a body.md with just the contents(without title) for the issue and calculate the next upcoming release version as a series of bash builtin commands.

@anoopcs9 anoopcs9 force-pushed the gh-cmd-issue-create branch from 855db3e to 829e15d Compare May 9, 2025 11:00
anoopcs9 added 3 commits May 9, 2025 23:49
This is done in preparation to make things easier for us to create
github issues using `gh` command line.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
With the third party github actions disabled we directly make use of
`gh` command line to create a bare minimum GitHub issue for any API
updates to be performed in the next upcoming release.

Signed-off-by: Anoop C S <anoopcs@cryptolab.net>
@anoopcs9 anoopcs9 force-pushed the gh-cmd-issue-create branch from 829e15d to ecdbc58 Compare May 9, 2025 18:29
@anoopcs9 anoopcs9 requested a review from phlogistonjohn May 9, 2025 18:36
Copy link
Collaborator

@phlogistonjohn phlogistonjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me

mergify bot added a commit that referenced this pull request May 10, 2025
@mergify mergify bot merged commit 11f1312 into ceph:master May 10, 2025
14 of 16 checks passed
@anoopcs9 anoopcs9 deleted the gh-cmd-issue-create branch May 13, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-API This PR does not include any changes to the public API of a go-ceph package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants